-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: check if GetStore returns nil (#4347) #4381
*: check if GetStore returns nil (#4347) #4381
Conversation
close tikv#4344 Signed-off-by: disksing <i@disksing.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 37639a4
|
/run-unit-tests |
2 similar comments
/run-unit-tests |
/run-unit-tests |
Codecov Report
@@ Coverage Diff @@
## release-5.2 #4381 +/- ##
===============================================
- Coverage 74.86% 74.75% -0.12%
===============================================
Files 249 249
Lines 25641 25653 +12
===============================================
- Hits 19197 19176 -21
- Misses 4770 4790 +20
- Partials 1674 1687 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This is an automated cherry-pick of #4347
close #4344
Signed-off-by: disksing i@disksing.com
What problem does this PR solve?
If we use
remove tombstone
,GetStore
may return nil. We should check it.What is changed and how it works?
Check List
Tests
Related changes
Release note