-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to pause scheduling on specific regions #4620
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: lightmelodies <lightmelodies@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #4620 +/- ##
==========================================
- Coverage 74.76% 74.71% -0.05%
==========================================
Files 281 281
Lines 27706 27784 +78
==========================================
+ Hits 20714 20760 +46
- Misses 5131 5168 +37
+ Partials 1861 1856 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There are some problems with current region labels implemention.
Anyway, This PR can be changed to use region labels strategy by modify IsRegionPinned 's implemention like this, which is not a huge work. |
region label +1 |
@lightmelodies: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi, @lightmelodies. Thanks for your contribution. Sorry for that I ignored the changed commit with the region label. I saw you reviewed the pr #4649, which already meets a part of your requirement. and why you need a region ID rather than the |
Not really need |
Thank your contribution. |
What problem does this PR solve?
Currently Pd can only pause scheduler for whole cluster, which does not work well for online bulk load. This PR add support to pause scheduling on specific regions.
What is changed and how it works?
Check List
Tests
Release note