-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server/schedule/labeler: support schedule-disabled for region #4649
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
1c296e2
to
ae569f6
Compare
Signed-off-by: shirly <AndreMouche@126.com>
ae569f6
to
d279c3a
Compare
Codecov Report
@@ Coverage Diff @@
## master #4649 +/- ##
==========================================
- Coverage 74.99% 74.98% -0.02%
==========================================
Files 282 282
Lines 27776 27791 +15
==========================================
+ Hits 20831 20839 +8
- Misses 5083 5088 +5
- Partials 1862 1864 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will schedulers still work on the range? such as balance-region-scheduler
Signed-off-by: shirly <AndreMouche@126.com>
yes |
Signed-off-by: shirly <AndreMouche@126.com>
Signed-off-by: shirly <AndreMouche@126.com>
Signed-off-by: shirly <AndreMouche@126.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
l := cl.GetRegionLabeler() | ||
if l.ScheduleDisabled(region) { | ||
log.Debug("schedule disabled", zap.Uint64("region-id", op.RegionID())) | ||
operatorWaitCounter.WithLabelValues(op.Desc(), "schedule-disabled").Inc() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we missing these metrics in Grafana. need to update the template in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Signed-off-by: shirly <AndreMouche@126.com>
Signed-off-by: shirly <AndreMouche@126.com>
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: bd6ce2e
|
[FORMAT CHECKER NOTIFICATION] Notice: Please provide the linked issue number on one line in the PR body, for example: 📖 For more info, you can check the "Linking issues" section in the CONTRIBUTING.md. |
Signed-off-by: shirly AndreMouche@126.com
What problem does this PR solve?
This PR is going to support disabling schedule for the region.
What is changed and how it work?
From TiDB(SQL)
with the above labels, the regions for the table would stop schedule except operators generated by
join state checker
. However, we can still create operators manually bypd-ctl
(admin)It works with region-label, for example:
Check List
Tests
Release note