Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TiDB Dashboard to v2022.03.16.1 ref #4257 #4740

Merged
merged 3 commits into from
Mar 17, 2022

Conversation

shhdgit
Copy link
Contributor

@shhdgit shhdgit commented Mar 16, 2022

Signed-off-by: Suhaha jklopsdfw@gmail.com

What problem does this PR solve?

Issue Number: ref #4257

Update TiDB Dashboard to v2022.03.16.1.

Related tidb-dashboard PR pingcap/tidb-dashboard#1199

  • Fix conprof profile URL
  • Fix missing fields in slow query
  • Telemetries of top SQL and conprof

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch
    • 5.4
    • 6.0

Release note

1. Fix conprof profile URL
2. Fix missing fields in slow query
3. Telemetries of top SQL and conprof

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 16, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 16, 2022
@ti-chi-bot ti-chi-bot requested review from HunDunDM and nolouch March 16, 2022 14:07
@github-actions github-actions bot added component/visualization Visualization. require-LGT1 Indicates that the PR requires an LGTM. labels Mar 16, 2022
Signed-off-by: Suhaha <jklopsdfw@gmail.com>
@shhdgit shhdgit force-pushed the update-dashboard-0316 branch from 57f6875 to a5be18c Compare March 16, 2022 14:12
Signed-off-by: Suhaha <jklopsdfw@gmail.com>
@breezewish
Copy link
Member

/build

@breezewish
Copy link
Member

/test

@breezewish breezewish mentioned this pull request Mar 16, 2022
@breezewish
Copy link
Member

/run-all-tests

Signed-off-by: Suhaha <jklopsdfw@gmail.com>
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #4740 (06838dc) into master (7e26092) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4740      +/-   ##
==========================================
- Coverage   75.09%   75.05%   -0.05%     
==========================================
  Files         284      284              
  Lines       28022    28038      +16     
==========================================
  Hits        21043    21043              
- Misses       5113     5124      +11     
- Partials     1866     1871       +5     
Flag Coverage Δ
unittests 75.05% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/balance_leader.go 92.30% <100.00%> (+0.12%) ⬆️
tools/pd-ctl/pdctl/command/scheduler.go 75.37% <100.00%> (+0.76%) ⬆️
server/tso/local_allocator.go 64.86% <0.00%> (-13.52%) ⬇️
pkg/metricutil/metricutil.go 82.75% <0.00%> (-10.35%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
pkg/dashboard/adapter/manager.go 78.72% <0.00%> (-4.26%) ⬇️
tools/pd-ctl/pdctl/command/operator.go 66.66% <0.00%> (-1.15%) ⬇️
server/tso/tso.go 61.71% <0.00%> (-1.15%) ⬇️
server/schedule/operator/step.go 74.07% <0.00%> (-1.02%) ⬇️
server/tso/allocator_manager.go 62.92% <0.00%> (-0.90%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a353ae...06838dc. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 17, 2022
@nolouch
Copy link
Contributor

nolouch commented Mar 17, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 06838dc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2022
@HunDunDM
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 844d138 into tikv:master Mar 17, 2022
rleungx pushed a commit to rleungx/pd that referenced this pull request Mar 17, 2022
ref tikv#4257

Signed-off-by: Suhaha <jklopsdfw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/visualization Visualization. release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants