checker: migrate test framework to testify #5174
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
the
release-note-none
rleungx
added
the
do-not-merge/work-in-progress
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
removed
the
do-not-merge/work-in-progress
Codecov Report
@@ Coverage Diff @@
## master #5174 +/- ##
==========================================
+ Coverage 75.71% 75.72% +0.01%
==========================================
Files 310 310
Lines 30648 30686 +38
==========================================
+ Hits 23204 23238 +34
+ Misses 5449 5448 -1
- Partials 1995 2000 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
pkg/testutil/operator_check.go
Outdated
| func CheckSteps(re *require.Assertions, op *operator.Operator, steps []operator.OpStep) { | ||
| re.NotEqual(0, op.Kind()&operator.OpMerge) | ||
| re.NotNil(steps) | ||
| re.Equal(len(steps), op.Len()) |
There was a problem hiding this comment.
| re.Equal(len(steps), op.Len()) | |
| re.Len(steps, op.Len()) |
|
|
||
| c.Assert(op.Len(), Equals, len(steps)) | ||
| re.Equal(len(steps), op.Len()) |
| ctx context.Context | ||
| cancel context.CancelFunc | ||
| cluster *mockcluster.Cluster | ||
| mc *MergeChecker | ||
| regions []*core.RegionInfo | ||
| } | ||
|
|
||
| func (s *testMergeCheckerSuite) SetUpSuite(c *C) { | ||
| s.ctx, s.cancel = context.WithCancel(context.Background()) | ||
| func TestMergeCheckerSuite(t *testing.T) { |
There was a problem hiding this comment.
| func TestMergeCheckerSuite(t *testing.T) { | |
| func TestMergeCheckerTestSuite(t *testing.T) { |
Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot
added
status/LGT2
|
/merge |
|
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: fe435a9
|
ti-chi-bot
added
the
status/can-merge
|
@rleungx: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ref tikv#4813 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: Ryan Leung rleungx@gmail.com
What problem does this PR solve?
Issue Number: Ref #4813.
What is changed and how does it work?
Check List
Tests
Release note