Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for Test Restructure #4813

Closed
85 tasks done
JmPotato opened this issue Apr 15, 2022 · 9 comments
Closed
85 tasks done

Tracking Issue for Test Restructure #4813

JmPotato opened this issue Apr 15, 2022 · 9 comments
Labels
component/testing CI testing. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement. type/refactor The issue belongs to a refactor work.

Comments

@JmPotato
Copy link
Member

JmPotato commented Apr 15, 2022 •
edited
Loading

This is the tracking issue for restructuring PD tests, focusing on unit tests and integration tests, especially on unifying test infrastructure in testify. See pingcap/tidb#26022 for more details on the TiDB side. Before you start, please read the code of conduct below carefully.

Code of Conduct

  • Make the PR as small as possible.
    • Modify only one or two packages at a time if possible.
    • Only focus on the test framework migration work, do not change the test logic. If you feel there is a strong need to refactor some tests, please file an issue to work on it later.
  • Carefully use the suite of testify because it runs its inside tests serially.
  • If a test needs to run a mock test cluster or something that is not lightweight, it's a good idea to put several tests inside a single suite to ensure maximum resource sharing.
  • If you need to call require.Xxx(t, a, b) multiple times, please create a re := require.New(t) first to avoid passing the t all around.
  • Use only require.Xxx or suite.Xxx whenever possible, do not mix the two.
  • For a function that will return error type, please use require.NoError/Error rather than require.Nil/NotNil.
  • For an equality comparison, please place the expected value as the first argument to fit the function signature, which will make the error message clear if the test fails.
    • re.Equal(expected, actual) ✅
    • re.Equal(actual, expected) ❌
  • Comment on this issue first to tell others which package you will work on.

Migration

Mics
@JmPotato JmPotato added type/enhancement The issue or PR belongs to an enhancement. component/testing CI testing. labels Apr 15, 2022
@JmPotato JmPotato mentioned this issue May 27, 2022
Merged
@tisonkun tisonkun mentioned this issue May 30, 2022
Closed
@rleungx rleungx pinned this issue May 30, 2022
ti-chi-bot pushed a commit that referenced this issue May 30, 2022
@JmPotato @nolouch
apiutil, audit, autoscaling, cache: testify the tests (#5061)
6c9f8f6 
ref #4813

Testify the pkg/apiutil, pkg/audit, pkg/autoscaling, pkg/cache tests.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: ShuNing <nolouch@gmail.com>
@JmPotato JmPotato mentioned this issue May 30, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue May 30, 2022
@JmPotato
codec, encryption, errs: testify the tests (#5066)
109719f 
ref #4813

Testify the pkg/codec, pkg/encryption, pkg/errs tests.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@rleungx rleungx added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels May 30, 2022
@JmPotato JmPotato mentioned this issue May 30, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue May 30, 2022
@JmPotato
assertutil, etcdutil, grpcutil, keyutil, logutil, metricutil: testify…
294a016 
… the tests (#5067)

ref #4813

Testify the pkg/assertutil, pkg/etcdutil, pkg/grpcutil, pkg/keyutil, pkg/logutil, pkg/metricutil tests.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato mentioned this issue May 31, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue May 31, 2022
@JmPotato
*: use require.New to reduce code (#5076)
bd79cc2 
ref #4813

Use `require.New` to reduce code.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato mentioned this issue May 31, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue Jun 1, 2022
@JmPotato
client, tests: testify the client tests (#5081)
ce6b35d 
ref #4813

Testify the client tests.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
This was referenced Jun 1, 2022
Merged
Open
ti-chi-bot pushed a commit that referenced this issue Jun 1, 2022
@JmPotato
mockhbstream, movingaverage, netutil, progress: testify the tests (#5086
422acfb 
)

ref #4813

Testify the pkg/mockhbstream, pkg/movingaverage, pkg/netutil, pkg/progress tests.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato mentioned this issue Jun 2, 2022
Merged
ti-chi-bot added a commit that referenced this issue Jun 2, 2022
@JmPotato @ti-chi-bot
* : testify all pkg tests (#5091)
fc55b44 
ref #4813

Testify all pkg tests.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@JmPotato JmPotato mentioned this issue Jun 2, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue Jun 2, 2022
@JmPotato
api: fix the testServiceSuite (#5096)
d114cd6 
ref #4813

Fix the `testServiceSuite`.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@rleungx rleungx mentioned this issue Jun 6, 2022
Merged
@LLThomas LLThomas mentioned this issue Jun 6, 2022
Merged
ti-chi-bot added a commit that referenced this issue Jun 7, 2022
@rleungx @ti-chi-bot
config: migrate test framework to testify (#5103)
e244adb 
ref #4813

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this issue Jun 7, 2022
@LLThomas @ti-chi-bot
kv: migrate test framework to testify (#5111)
36db3c7 
ref #4813

Signed-off-by: LLThomas <zs033@qq.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@JmPotato JmPotato mentioned this issue Jun 7, 2022
Merged
@rleungx rleungx mentioned this issue Jun 8, 2022
Merged
@JmPotato JmPotato mentioned this issue Jun 8, 2022
Merged
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@JmPotato @ti-chi-bot @CabinfeverB
tests: testify the TSO tests (tikv#5169)
134baae 
ref tikv#4813

Testify the TSO tests.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@lhy1024 @ti-chi-bot @CabinfeverB
operator: migrate test framework to testify (tikv#5191)
448d689 
ref tikv#4813

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@lhy1024 @ti-chi-bot @CabinfeverB
bucket: migrate test framework to testify (tikv#5195)
85f79bf 
ref tikv#4813

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@lhy1024 @CabinfeverB
*: replace re.Len 0 with re.Empty (tikv#5210)
7014489 
ref tikv#4813

Signed-off-by: lhy1024 <admin@liudos.us>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@lhy1024 @ti-chi-bot @CabinfeverB
tests/server: migrate test framework to testify (tikv#5197)
2c5e434 
ref tikv#4813

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@rleungx @ti-chi-bot @CabinfeverB
*: migrate test framework to testify (tikv#5193)
c0a6b11 
ref tikv#4813

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@JmPotato @CabinfeverB
tests: testify some server tests (tikv#5186)
c8ce97c 
ref tikv#4813

Testify some server tests.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@lhy1024 @ti-chi-bot @CabinfeverB
*: some misc modify for testify (tikv#5211)
187e514 
ref tikv#4813, ref tikv#5193

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@LLThomas @CabinfeverB
pkg/testutil: add a WithTestify func for CheckTransferLeader (tikv#5213)
eb77f6b 
ref tikv#4813

Add a WithTestify func for CheckTransferLeader and CheckTransferLeaderWithTestify will be used in server/cluster/coordinator_test.go.

Signed-off-by: LLThomas <zs033@qq.com>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@JmPotato @CabinfeverB
scripts, tests: update the check-test.sh to detect more inefficient a…
29fc365 
…ssert functions (tikv#5219)

ref tikv#4813

Update the check-test.sh to detect more inefficient assert functions.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@lhy1024 @ti-chi-bot @CabinfeverB
server: migrate test framework to testify (tikv#5198)
bcff7c2 
ref tikv#4813, ref tikv#5193

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@LLThomas @CabinfeverB
server/cluster: migrate test framework to testify (tikv#5203)
bee2eb3 
ref tikv#4813

As the title says.

Signed-off-by: LLThomas <zs033@qq.com>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@rleungx @CabinfeverB
*: remove duplicated functions (tikv#5224)
45a45cb 
ref tikv#4813

Signed-off-by: Ryan Leung <rleungx@gmail.com>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@lhy1024 @ti-chi-bot @CabinfeverB
schedule: migrate test framework to testify (tikv#5196)
e0d2500 
ref tikv#4813

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@JmPotato @CabinfeverB
*: clean up the surrounding code of check pkg (tikv#5225)
1c26652 
ref tikv#4813, close tikv#5105

Clean up the surrounding code of check pkg.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@rleungx @CabinfeverB
*: unify the must wait leader (tikv#5226)
201c545 
ref tikv#4813

Signed-off-by: Ryan Leung <rleungx@gmail.com>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@JmPotato @CabinfeverB
tests: testify the global_config tests (tikv#5227)
3528b71 
ref tikv#4813

Testify the global_config tests.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@lhy1024 @ti-chi-bot @CabinfeverB
operator: migrate test framework to testify (tikv#5229)
396641f 
ref tikv#4813

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@lhy1024 @CabinfeverB
*: some misc modify for testify (tikv#5239)
fae47ab 
ref tikv#4813

Signed-off-by: lhy1024 <admin@liudos.us>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@lhy1024 @CabinfeverB
*: some misc modify for testify (tikv#5299)
e566e73 
ref tikv#4813

Signed-off-by: lhy1024 <admin@liudos.us>
@JmPotato JmPotato unpinned this issue Jul 14, 2022
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@lhy1024 @CabinfeverB
*: some misc modify for testify (tikv#5299)
8b680a8 
ref tikv#4813

Signed-off-by: lhy1024 <admin@liudos.us>
@rleungx rleungx mentioned this issue Jul 20, 2022
Merged
ti-chi-bot added a commit that referenced this issue Jul 25, 2022
@rleungx @ti-chi-bot
*: clean up the leak options (#5336)
7187a7a 
ref #4813

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@JmPotato JmPotato mentioned this issue Dec 19, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Dec 20, 2023
@JmPotato
tests: fix some errors detected by testifylint (#7580)
59c9d04 
ref #4813

Fix some errors detected by `testifylint`.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato mentioned this issue Dec 20, 2023
Merged
ti-chi-bot bot added a commit that referenced this issue Dec 21, 2023
@JmPotato @ti-chi-bot
tests: fix all errors detected by testifylint and enable it (#7589)
7f156d9 
ref #4813

Fix all errors detected by testifylint and enable it.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@JmPotato JmPotato mentioned this issue Dec 21, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Dec 21, 2023
@JmPotato
tests, Makefile: fix the TSO consistency test (#7603)
d4ebef8 
ref #4813

Fix the TSO consistency test.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/testing CI testing. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement. type/refactor The issue belongs to a refactor work.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@JmPotato @nolouch @lhy1024 @HunDunDM @rleungx @LLThomas