tests: fix some errors detected by testifylint #7580
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
release-note-none
JmPotato
force-pushed
the
use_testifylint
branch
3 times, most recently
from
5f2588e
to
7f50638
Compare
Signed-off-by: JmPotato <ghzpotato@gmail.com>
JmPotato
force-pushed
the
use_testifylint
branch
from
7f50638
to
1787368
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7580 +/- ##
==========================================
+ Coverage 74.75% 74.77% +0.01%
==========================================
Files 457 457
Lines 50351 50351
==========================================
+ Hits 37639 37648 +9
+ Misses 9375 9373 -2
+ Partials 3337 3330 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -201,16 +205,14 @@ func (suite *balanceSchedulerPlanAnalyzeTestSuite) TestAnalyzerResult4() { | |||
| plans = append(plans, &BalanceSchedulerPlan{Source: suite.stores[1], Target: suite.stores[1], Step: 2, Status: NewStatus(StatusStoreAlreadyHasPeer)}) | |||
| plans = append(plans, &BalanceSchedulerPlan{Source: suite.stores[1], Target: suite.stores[2], Step: 2, Status: NewStatus(StatusStoreNotMatchRule)}) | |||
| plans = append(plans, &BalanceSchedulerPlan{Source: suite.stores[1], Target: suite.stores[3], Step: 2, Status: NewStatus(StatusStoreNotMatchRule)}) | |||
| plans = append(plans, &BalanceSchedulerPlan{Source: suite.stores[1], Target: suite.stores[4], Step: 2, Status: NewStatus(StatusStoreDown)}) | |||
There was a problem hiding this comment.
I used Copilot on this test, it mistakenly modified some additional content, but I have changed it back. PTAL.
Signed-off-by: JmPotato <ghzpotato@gmail.com>
ti-chi-bot
bot
added
status/LGT2
|
/merge |
|
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 7372a96
|
ti-chi-bot
bot
added
the
status/can-merge
What problem does this PR solve?
Issue Number: ref #4813.
What is changed and how does it work?
Check List
Tests
Release note