Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: fix a bug that could not handle proxy requests correctly (#5326) #5356

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5326

What problem does this PR solve?

Issue Number: Close #5321

What is changed and how does it work?

Only process headers added by PD.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

Fix a bug that could not handle dashboard proxy requests correctly.

HunDunDM added 3 commits July 26, 2022 06:40
Signed-off-by: HunDunDM <hundundm@gmail.com>
Signed-off-by: HunDunDM <hundundm@gmail.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 26, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 26, 2022
@ti-chi-bot ti-chi-bot added type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Jul 26, 2022
@ti-chi-bot ti-chi-bot requested review from HunDunDM and rleungx July 26, 2022 06:41
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 29, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 20, 2022
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch
Copy link
Contributor

nolouch commented Sep 20, 2022

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 57c256a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 20, 2022
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@nolouch
Copy link
Contributor

nolouch commented Sep 20, 2022

/rebuild

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Base: 74.67% // Head: 74.75% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (1b5e9ac) compared to base (d59e6ce).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-5.4    #5356      +/-   ##
===============================================
+ Coverage        74.67%   74.75%   +0.08%     
===============================================
  Files              265      265              
  Lines            28002    28003       +1     
===============================================
+ Hits             20911    20935      +24     
+ Misses            5225     5204      -21     
+ Partials          1866     1864       -2     
Flag Coverage Δ
unittests 74.75% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/dashboard/adapter/redirector.go 91.30% <100.00%> (+6.85%) ⬆️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
pkg/dashboard/adapter/manager.go 78.72% <0.00%> (-4.26%) ⬇️
server/region_syncer/client.go 79.84% <0.00%> (-3.88%) ⬇️
server/election/lease.go 86.15% <0.00%> (-1.54%) ⬇️
server/server.go 70.78% <0.00%> (-0.90%) ⬇️
server/tso/allocator_manager.go 64.05% <0.00%> (-0.84%) ⬇️
server/grpc_service.go 51.25% <0.00%> (-0.20%) ⬇️
server/cluster/coordinator.go 74.78% <0.00%> (+0.42%) ⬆️
server/core/storage.go 69.31% <0.00%> (+0.75%) ⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot merged commit 20e9dda into tikv:release-5.4 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants