Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal proxy cannot work as expected #5321

Closed
rleungx opened this issue Jul 18, 2022 · 0 comments · Fixed by #5326
Closed

Internal proxy cannot work as expected #5321

rleungx opened this issue Jul 18, 2022 · 0 comments · Fixed by #5326
Labels
affects-5.0 affects-5.1 affects-5.2 affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.

Comments

@rleungx
Copy link
Member

rleungx commented Jul 18, 2022 •
edited
Loading

Bug Report

What did you do?

Add an external load balancer above PD and enable the internal proxy.

What did you expect to see?

The internal proxy can work.

What did you see instead?

Return 508 error.

Because we check if Via header is existed to prevent the loop, but the external proxy maybe already have this header. Once the request is sent to the PD follower, it will be rejected due to the check.

What version of PD are you using (pd-server -V)?

master
@rleungx rleungx added the type/bug The issue is confirmed as a bug. label Jul 18, 2022
@HunDunDM HunDunDM mentioned this issue Jul 18, 2022
Merged
@nolouch nolouch added affects-6.1 This bug affects the 6.1.x(LTS) versions. severity/major labels Jul 21, 2022
ti-chi-bot added a commit that referenced this issue Jul 21, 2022
@HunDunDM @nolouch @ti-chi-bot
dashboard: fix a bug that could not handle proxy requests correctly (#…
3480a62 
…5326)

close #5321

Signed-off-by: HunDunDM <hundundm@gmail.com>

Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Jul 21, 2022
Merged
This was referenced Jul 26, 2022
Merged
Merged
This was referenced Jul 26, 2022
Merged
Merged
Merged
This was referenced Jul 27, 2022
Closed
Merged
ti-chi-bot pushed a commit that referenced this issue Jul 27, 2022
@HunDunDM
dashboard: fix a bug that could not handle proxy requests correctly (#…
d139da4 
…5326) (#5365)

close #5321, ref #5326

Signed-off-by: HunDunDM <hundundm@gmail.com>
ti-chi-bot added a commit that referenced this issue Sep 20, 2022
@ti-chi-bot @HunDunDM @nolouch
dashboard: fix a bug that could not handle proxy requests correctly (#…
045570e 
…5326) (#5357)

close #5321, ref #5326

Signed-off-by: HunDunDM <hundundm@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>

Co-authored-by: HunDunDM <hundundm@gmail.com>
Co-authored-by: nolouch <nolouch@gmail.com>
ti-chi-bot added a commit that referenced this issue Sep 20, 2022
@ti-chi-bot @HunDunDM @nolouch
dashboard: fix a bug that could not handle proxy requests correctly (#…
18c6ba6 
…5326) (#5345)

close #5321, ref #5326

Signed-off-by: HunDunDM <hundundm@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>

Co-authored-by: HunDunDM <hundundm@gmail.com>
Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: nolouch <nolouch@gmail.com>
ti-chi-bot added a commit that referenced this issue Sep 20, 2022
@ti-chi-bot @HunDunDM @nolouch
dashboard: fix a bug that could not handle proxy requests correctly (#…
20e9dda 
…5326) (#5356)

close #5321, ref #5326

Signed-off-by: HunDunDM <hundundm@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>

Co-authored-by: HunDunDM <hundundm@gmail.com>
Co-authored-by: nolouch <nolouch@gmail.com>
ti-chi-bot added a commit that referenced this issue Sep 20, 2022
@ti-chi-bot @HunDunDM @nolouch
dashboard: fix a bug that could not handle proxy requests correctly (#…
a2fe396 
…5326) (#5355)

close #5321, ref #5326

Signed-off-by: HunDunDM <hundundm@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>

Co-authored-by: HunDunDM <hundundm@gmail.com>
Co-authored-by: nolouch <nolouch@gmail.com>
ti-chi-bot added a commit that referenced this issue Sep 20, 2022
@ti-chi-bot @HunDunDM @nolouch
dashboard: fix a bug that could not handle proxy requests correctly (#…
2fe83e1 
…5326) (#5354)

close #5321, ref #5326

Signed-off-by: HunDunDM <hundundm@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>

Co-authored-by: HunDunDM <hundundm@gmail.com>
Co-authored-by: nolouch <nolouch@gmail.com>
ti-chi-bot added a commit that referenced this issue Sep 20, 2022
@ti-chi-bot @HunDunDM @nolouch
dashboard: fix a bug that could not handle proxy requests correctly (#…
fd64d04 
…5326) (#5353)

close #5321, ref #5326

Signed-off-by: HunDunDM <hundundm@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>

Co-authored-by: HunDunDM <hundundm@gmail.com>
Co-authored-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.0 affects-5.1 affects-5.2 affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dashboard: fix a bug that could not handle proxy requests correctly HunDunDM/pd
4 participants
@nolouch @VelocityLight @rleungx @ti-chi-bot