Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: fix a bug that could not handle proxy requests correctly (#5326) #5357

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5326

What problem does this PR solve?

Issue Number: Close #5321

What is changed and how does it work?

Only process headers added by PD.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

Fix a bug that could not handle dashboard proxy requests correctly.

HunDunDM added 3 commits July 26, 2022 06:40
Signed-off-by: HunDunDM <hundundm@gmail.com>
Signed-off-by: HunDunDM <hundundm@gmail.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 26, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.3 The PR belongs to release-5.3 cherry pick. labels Jul 26, 2022
@ti-chi-bot ti-chi-bot requested review from HunDunDM and lhy1024 July 26, 2022 06:41
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Base: 75.01% // Head: 75.08% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (28dd7fe) compared to base (eea08fb).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 28dd7fe differs from pull request most recent head 67e9cf9. Consider uploading reports for the commit 67e9cf9 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           release-5.3    #5357      +/-   ##
===============================================
+ Coverage        75.01%   75.08%   +0.07%     
===============================================
  Files              263      263              
  Lines            27359    27360       +1     
===============================================
+ Hits             20522    20543      +21     
+ Misses            5024     5014      -10     
+ Partials          1813     1803      -10     
Flag Coverage Δ
unittests 75.08% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/dashboard/adapter/redirector.go 91.30% <100.00%> (+6.85%) ⬆️
pkg/cache/lru.go 79.06% <0.00%> (-9.31%) ⬇️
server/region_syncer/client.go 75.19% <0.00%> (-4.66%) ⬇️
pkg/etcdutil/etcdutil.go 84.70% <0.00%> (-3.53%) ⬇️
server/tso/tso.go 67.97% <0.00%> (-2.81%) ⬇️
server/member/member.go 63.10% <0.00%> (-2.14%) ⬇️
client/base_client.go 79.89% <0.00%> (-2.07%) ⬇️
pkg/btree/btree.go 85.78% <0.00%> (-0.97%) ⬇️
server/cluster/coordinator.go 74.36% <0.00%> (-0.43%) ⬇️
server/schedule/operator_controller.go 83.84% <0.00%> (-0.41%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 26, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 27, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 17, 2022
@nolouch
Copy link
Contributor

nolouch commented Aug 17, 2022

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 28dd7fe

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 17, 2022
Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Sep 20, 2022
@nolouch
Copy link
Contributor

nolouch commented Sep 20, 2022

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 67e9cf9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 20, 2022
@ti-chi-bot ti-chi-bot merged commit 045570e into tikv:release-5.3 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.3 The PR belongs to release-5.3 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants