pkg: use minimum interface for schedulers #6553

rleungx · 2023-06-02T08:56:49Z

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

This PR relies on #6551, please review it after #6551 is merged.

It introduces a minimum interface for schedulers. Once all functions within this interface are implemented, we can run the schedulers.

Check List

Tests

Unit test

Release note

None.

ti-chi-bot · 2023-06-02T08:56:51Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

lhy1024
nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov · 2023-06-02T09:26:53Z

Codecov Report

Patch coverage: 73.68% and project coverage change: +0.03 🎉

Comparison is base (f290e66) 74.66% compared to head (9592b12) 74.69%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6553      +/-   ##
==========================================
+ Coverage   74.66%   74.69%   +0.03%     
==========================================
  Files         417      417              
  Lines       42694    42693       -1     
==========================================
+ Hits        31876    31891      +15     
+ Misses       8007     7995      -12     
+ Partials     2811     2807       -4

Flag	Coverage Δ
unittests	`74.69% <73.68%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/mock/mockcluster/mockcluster.go	`93.83% <ø> (+0.20%)`	⬆️
pkg/schedule/checker/merge_checker.go	`70.99% <ø> (ø)`
pkg/schedule/config/config.go	`33.33% <ø> (ø)`
pkg/schedule/filter/healthy.go	`100.00% <ø> (ø)`
pkg/schedule/filter/region_filters.go	`86.79% <ø> (ø)`
pkg/schedule/operator/create_operator.go	`91.77% <ø> (ø)`
pkg/schedule/schedulers/balance_region.go	`88.02% <ø> (ø)`
pkg/schedule/schedulers/balance_witness.go	`66.86% <ø> (ø)`
pkg/schedule/schedulers/evict_leader.go	`81.28% <ø> (-0.99%)`	⬇️
pkg/schedule/schedulers/evict_slow_store.go	`75.90% <ø> (ø)`
... and 20 more

... and 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

lhy1024 · 2023-06-06T10:36:48Z

pkg/schedule/filter/healthy.go

@@ -42,17 +42,17 @@ func hasDownPeers(region *core.RegionInfo) bool {
 // IsRegionReplicated checks if a region is fully replicated. When placement
 // rules is enabled, its peers should fit corresponding rules. When placement
 // rules is disabled, it should have enough replicas and no any learner peer.
-func IsRegionReplicated(cluster sche.RegionHealthCluster, region *core.RegionInfo) bool {
+func IsRegionReplicated(cluster sche.ScheduleCluster, region *core.RegionInfo) bool {


sche.ScheduleCluster reads like a stutter

rleungx · 2023-06-08T08:46:56Z

/merge

rleungx · 2023-06-09T01:42:10Z

/merge

ti-chi-bot · 2023-06-09T01:42:12Z

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-09T01:42:13Z

This pull request has been accepted and is ready to merge.

Commit hash: 84beac2

ti-chi-bot · 2023-06-09T03:46:57Z

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx · 2023-06-09T07:31:31Z

/merge

ti-chi-bot · 2023-06-09T07:31:32Z

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-09T07:31:34Z

This pull request has been accepted and is ready to merge.

Commit hash: 9592b12

ref #5839, ref #6553 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

ref tikv#5839, ref tikv#6551 Signed-off-by: Ryan Leung <rleungx@gmail.com>

ref tikv#5839, ref tikv#6553 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 2, 2023

ti-chi-bot bot requested review from HunDunDM and lhy1024 June 2, 2023 08:57

rleungx force-pushed the split-scheduler branch from 3eafa8f to 51caadd Compare June 2, 2023 09:10

rleungx requested review from JmPotato and nolouch and removed request for lhy1024 and HunDunDM June 2, 2023 09:10

lhy1024 self-requested a review June 5, 2023 03:43

This was referenced Jun 6, 2023

config, cluster: add an option to halt the cluster scheduling #6498

Merged

*: extract conn and replace GetAllocator #6557

Merged

ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2023

rleungx mentioned this pull request Jun 6, 2023

Separate scheduling into an independent service #5839

Closed

rleungx force-pushed the split-scheduler branch from 51caadd to 84beac2 Compare June 6, 2023 09:20

ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2023

lhy1024 approved these changes Jun 6, 2023

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 6, 2023

nolouch approved these changes Jun 8, 2023

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 8, 2023

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 9, 2023

rleungx added 2 commits June 9, 2023 12:44

remove unnecessary interfaces

6f3637f

Signed-off-by: Ryan Leung <rleungx@gmail.com>

use minimum interface for schedulers

53bd3ce

Signed-off-by: Ryan Leung <rleungx@gmail.com>

resolve the conflicts

9592b12

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx force-pushed the split-scheduler branch from ef1042f to 9592b12 Compare June 9, 2023 04:51

ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 9, 2023

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 9, 2023

ti-chi-bot bot merged commit 181e613 into tikv:master Jun 9, 2023

rleungx deleted the split-scheduler branch June 9, 2023 07:32

ti-chi-bot bot added a commit that referenced this pull request Jun 15, 2023

*: extract conn and replace GetAllocator (#6557)

a0beaef

ref #5839, ref #6553 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023

pkg: use minimum interface for schedulers (tikv#6553)

247b7c8

ref tikv#5839, ref tikv#6551 Signed-off-by: Ryan Leung <rleungx@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pkg: use minimum interface for schedulers #6553

pkg: use minimum interface for schedulers #6553

rleungx commented Jun 2, 2023 •

edited

Loading

ti-chi-bot bot commented Jun 2, 2023 •

edited

Loading

codecov bot commented Jun 2, 2023 •

edited

Loading

lhy1024 Jun 6, 2023

rleungx commented Jun 8, 2023

rleungx commented Jun 9, 2023

ti-chi-bot bot commented Jun 9, 2023

ti-chi-bot bot commented Jun 9, 2023

ti-chi-bot bot commented Jun 9, 2023

rleungx commented Jun 9, 2023

ti-chi-bot bot commented Jun 9, 2023

ti-chi-bot bot commented Jun 9, 2023

pkg: use minimum interface for schedulers #6553

pkg: use minimum interface for schedulers #6553

Conversation

rleungx commented Jun 2, 2023 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Jun 2, 2023 • edited Loading

codecov bot commented Jun 2, 2023 • edited Loading

Codecov Report

lhy1024 Jun 6, 2023

Choose a reason for hiding this comment

rleungx commented Jun 8, 2023

rleungx commented Jun 9, 2023

ti-chi-bot bot commented Jun 9, 2023

ti-chi-bot bot commented Jun 9, 2023

ti-chi-bot bot commented Jun 9, 2023

rleungx commented Jun 9, 2023

ti-chi-bot bot commented Jun 9, 2023

ti-chi-bot bot commented Jun 9, 2023

rleungx commented Jun 2, 2023 •

edited

Loading

ti-chi-bot bot commented Jun 2, 2023 •

edited

Loading

codecov bot commented Jun 2, 2023 •

edited

Loading