Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: extract conn and replace GetAllocator #6557

Merged
merged 5 commits into from
Jun 15, 2023
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jun 6, 2023

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

Just as the title says. It should be reviewed after #6553 is merged.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 6, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 6, 2023
@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and nolouch June 6, 2023 04:34
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 88.09% and project coverage change: +0.09 🎉

Comparison is base (6afbcec) 74.57% compared to head (32ce0c0) 74.66%.

❗ Current head 32ce0c0 differs from pull request most recent head 4a28a46. Consider uploading reports for the commit 4a28a46 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6557      +/-   ##
==========================================
+ Coverage   74.57%   74.66%   +0.09%     
==========================================
  Files         417      415       -2     
  Lines       42896    42580     -316     
==========================================
- Hits        31990    31793     -197     
+ Misses       8079     7980      -99     
+ Partials     2827     2807      -20     
Flag Coverage Δ
unittests 74.66% <88.09%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/core/basic_cluster.go 93.75% <ø> (ø)
pkg/core/region.go 88.97% <ø> (ø)
pkg/schedule/checker/merge_checker.go 70.99% <ø> (ø)
pkg/schedule/filter/healthy.go 100.00% <ø> (ø)
pkg/schedule/operator/create_operator.go 91.77% <ø> (ø)
pkg/schedule/schedulers/evict_slow_store.go 75.90% <ø> (ø)
pkg/schedule/schedulers/evict_slow_trend.go 64.86% <ø> (ø)
pkg/schedule/schedulers/grant_hot_region.go 54.60% <ø> (ø)
pkg/schedule/schedulers/grant_leader.go 68.15% <0.00%> (ø)
pkg/schedule/schedulers/hot_region_config.go 93.85% <ø> (ø)
... and 37 more

... and 44 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2023
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 12, 2023
Copy link
Member

@CabinfeverB CabinfeverB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Jitter: 0.2, // Default
MaxDelay: 3 * time.Second, // Default was 120s.
},
MinConnectTimeout: 5 * time.Second,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we've extracted conn, how about extracting these parameters as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds great

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 12, 2023
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 15, 2023
@rleungx
Copy link
Member Author

rleungx commented Jun 15, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 15, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 15, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 06ddb44

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 15, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 15, 2023

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit a0beaef into tikv:master Jun 15, 2023
@rleungx rleungx deleted the extract-conn branch June 15, 2023 10:15
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
ref tikv#5839, ref tikv#6553

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants