Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: add http support for scheduling service #6960

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Aug 15, 2023

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 15, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 15, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and lhy1024 August 15, 2023 10:38
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #6960 (3920ab1) into master (497c942) will decrease coverage by 0.21%.
The diff coverage is 39.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6960      +/-   ##
==========================================
- Coverage   74.36%   74.16%   -0.21%     
==========================================
  Files         427      433       +6     
  Lines       45351    45877     +526     
==========================================
+ Hits        33727    34024     +297     
- Misses       8661     8830     +169     
- Partials     2963     3023      +60     
Flag Coverage Δ
unittests 74.16% <39.75%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
}

// @Tags operators
// @Summary Get a Region's pending operator.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending operator?

Comment on lines 190 to 196
// @Tags checkers
// @Summary Get if checker is paused
// @Param name path string true "The name of the scheduler."
// @Produce json
// @Success 200 {string} string "Pause or resume the scheduler successfully."
// @Failure 500 {string} string "PD server failed to proceed the request."
// @Router /checkers/{name} [get]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update comments?

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 21, 2023
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx requested a review from lhy1024 August 23, 2023 02:14
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 23, 2023
@rleungx
Copy link
Member Author

rleungx commented Aug 23, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 23, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 23, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 909579d

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 23, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 23, 2023

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit de5f53e into tikv:master Aug 23, 2023
21 of 23 checks passed
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
ref tikv#5839

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants