Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcs: init HTTP handler #6963

Merged
merged 3 commits into from
Aug 28, 2023
Merged

mcs: init HTTP handler #6963

merged 3 commits into from
Aug 28, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Aug 16, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

Need to merge #6960 first.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 16, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 16, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and lhy1024 August 16, 2023 09:40
@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 16, 2023
@rleungx rleungx requested review from JmPotato and removed request for disksing August 16, 2023 09:41
@rleungx rleungx mentioned this pull request Aug 16, 2023
Merged
@rleungx
init HTTP handler
0278b12 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
Copy link
Member Author

rleungx commented Aug 23, 2023

PTAL @JmPotato @lhy1024

@codecov
Copy link

codecov bot commented Aug 23, 2023 •
edited
Loading

Codecov Report

Merging #6963 (822af06) into master (6307aa8) will increase coverage by 0.04%.
The diff coverage is 72.72%.

❗ Current head 822af06 differs from pull request most recent head a9d1f23. Consider uploading reports for the commit a9d1f23 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6963      +/-   ##
==========================================
+ Coverage   74.21%   74.25%   +0.04%     
==========================================
  Files         433      433              
  Lines       46137    46046      -91     
==========================================
- Hits        34240    34193      -47     
+ Misses       8871     8847      -24     
+ Partials     3026     3006      -20
Flag Coverage Δ
unittests 74.25% <72.72%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx rleungx mentioned this pull request Aug 24, 2023
Closed
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 25, 2023
nolouch
nolouch reviewed Aug 28, 2023
View reviewed changes
cmd/pd-server/main.go Outdated
@@ -41,6 +41,11 @@ import (
"github.com/tikv/pd/server/config"
"github.com/tikv/pd/server/join"
"go.uber.org/zap"

// register microservice HTTP API
_ "github.com/tikv/pd/pkg/mcs/resourcemanager/server/apis/v1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why need this? Does install pkg duplicate with it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't import, the independent service cannot use the HTTP interface in the current implementation. There is an import cycle problem.

Copy link
Contributor

@nolouch nolouch Aug 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean why not

_ "github.com/tikv/pd/pkg/mcs/resourcemanager/server/install"
_ "github.com/tikv/pd/pkg/mcs/scheduling/server/install"
_ "github.com/tikv/pd/pkg/mcs/tso/server/apis/install"

make http and grpc register togeter. Does it exist import cycle? I think it's same with xxx/api.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@rleungx rleungx requested a review from nolouch August 28, 2023 04:11
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 28, 2023
@rleungx
address comments
57125f6 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
nolouch
nolouch approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nolouch
Copy link
Contributor

nolouch commented Aug 28, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 57125f6

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 28, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2023

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit cf86c7c into tikv:master Aug 28, 2023
22 checks passed
@rleungx rleungx deleted the init-service branch August 28, 2023 06:05
@lhy1024 lhy1024 mentioned this pull request Nov 1, 2023
Closed
25 tasks
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@rleungx @ti-chi-bot
mcs: init HTTP handler (tikv#6963)
05b0da7 
ref tikv#5839

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@nolouch nolouch nolouch approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rleungx @nolouch @JmPotato @lhy1024