mcs: support rules http interface in scheduling server #7199
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
Skipping CI for Draft Pull Request. |
ti-chi-bot
bot
added
do-not-merge/work-in-progress
Codecov Report
@@ Coverage Diff @@
## master #7199 +/- ##
==========================================
- Coverage 74.45% 74.39% -0.06%
==========================================
Files 446 446
Lines 48435 48705 +270
==========================================
+ Hits 36061 36235 +174
- Misses 9175 9249 +74
- Partials 3199 3221 +22
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
lhy1024
force-pushed
the
sche-redirect6
branch
from
6293007
to
d8cd97f
Compare
Signed-off-by: lhy1024 <admin@liudos.us>
lhy1024
force-pushed
the
sche-redirect6
branch
from
0af2ef9
to
077f284
Compare
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
server/api/rule.go
Outdated
| return | ||
| } | ||
| keyHex := mux.Vars(r)["key"] | ||
| key, err := hex.DecodeString(keyHex) | ||
| if err != nil { | ||
| h.rd.JSON(w, http.StatusBadRequest, "key should be in hex format") | ||
| h.rd.JSON(w, http.StatusBadRequest, errs.ErrKeyFormat.Error()) |
There was a problem hiding this comment.
Do we need to wrap err in ErrKeyFormat？
ti-chi-bot
bot
added
status/LGT2
Signed-off-by: lhy1024 <admin@liudos.us>
|
/merge |
|
@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 8e77510
|
ti-chi-bot
bot
added
the
status/can-merge
lhy1024
force-pushed
the
sche-redirect6
branch
from
f2b1eee
to
3fea084
Compare
ti-chi-bot
bot
removed
the
status/can-merge
|
/merge |
|
@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: c258d0e
|
ti-chi-bot
bot
added
the
status/can-merge
|
@lhy1024: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ref tikv#5839 Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
What problem does this PR solve?
Issue Number: Ref #5839
It can be reviewed after #7184 merged and #7200 solved
What is changed and how does it work?
Check List
Tests
Release note