Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcs: support placement rules in scheduling server #7200

Closed
lhy1024 opened this issue Oct 13, 2023 · 0 comments · Fixed by #7205
Closed

mcs: support placement rules in scheduling server #7200

lhy1024 opened this issue Oct 13, 2023 · 0 comments · Fixed by #7205
Assignees
@JmPotato
Labels
type/development The issue belongs to a development tasks

Comments

@lhy1024
Copy link
Contributor

lhy1024 commented Oct 13, 2023

Development Task

Now, we can watch the change of placement rules with ruleWatcher, but we don't use it in the scheduling server with GetRuleStorage, which should be supported.

BTW, after the change of placement rules, we also need to call AddSuspectKeyRange, which is similar to /config/rule [post], /config/rule/{group}/{id} [delete], /config/rule_group [post], /config/rule_group/{id} [delete]
@lhy1024 lhy1024 added the type/development The issue belongs to a development tasks label Oct 13, 2023
@lhy1024 lhy1024 mentioned this issue Oct 13, 2023
Merged
@JmPotato JmPotato self-assigned this Oct 16, 2023
@JmPotato JmPotato mentioned this issue Oct 16, 2023
Merged
ti-chi-bot bot added a commit that referenced this issue Oct 16, 2023
@JmPotato @ti-chi-bot
scheduling/watcher, storage: store rules into the unified storage (#7205
fa92039 
)

close #7200

Store rules into the unified storage rather than the isolated implementation.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@JmPotato JmPotato mentioned this issue Oct 16, 2023
Merged
rleungx pushed a commit to rleungx/pd that referenced this issue Dec 1, 2023
@JmPotato @ti-chi-bot @rleungx
scheduling/watcher, storage: store rules into the unified storage (ti…
31e3a23 
…kv#7205)

close tikv#7200

Store rules into the unified storage rather than the isolated implementation.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JmPotato JmPotato

Labels
type/development The issue belongs to a development tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

scheduling/watcher, storage: store rules into the unified storage JmPotato/pd
2 participants
@JmPotato @lhy1024