Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduling/watcher, storage: integrate rule watcher with the managers #7213

Merged
merged 6 commits into from
Oct 17, 2023
Merged

scheduling/watcher, storage: integrate rule watcher with the managers #7213

merged 6 commits into from
Oct 17, 2023

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Oct 16, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #5839, #7200.

What is changed and how does it work?

Integrate rule watcher with the managers.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 16, 2023
@JmPotato JmPotato mentioned this pull request Oct 16, 2023
Merged
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

Merging #7213 (2503865) into master (8b2896b) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 71.30%.

❗ Current head 2503865 differs from pull request most recent head d9260d4. Consider uploading reports for the commit d9260d4 to get more accurate results

@@           Coverage Diff           @@
##           master    #7213   +/-   ##
=======================================
  Coverage   74.65%   74.65%           
=======================================
  Files         442      442           
  Lines       47744    47836   +92     
=======================================
+ Hits        35642    35713   +71     
- Misses       8957     8963    +6     
- Partials     3145     3160   +15
Flag Coverage Δ
unittests 74.65% <71.30%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 17, 2023
@JmPotato
Integrate rule watcher with the managers
159ff37 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Only keep the integration test
11dbbb2 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Reload after setting
d99e141 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato force-pushed the integrate_watcher_rule_manager branch from 2503865 to d99e141 Compare October 17, 2023 06:23
@JmPotato
Clean up the comment
24dffe4 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 17, 2023
@JmPotato
Start rule watcher after cluster is created
a78485a 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato force-pushed the integrate_watcher_rule_manager branch from f216e26 to a78485a Compare October 17, 2023 08:45
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 17, 2023
@JmPotato
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 17, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 17, 2023

This pull request has been accepted and is ready to merge.

Commit hash: a78485a

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 17, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 17, 2023

@JmPotato: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit a85f29c into tikv:master Oct 17, 2023
22 checks passed
@JmPotato JmPotato deleted the integrate_watcher_rule_manager branch October 17, 2023 09:09
@rleungx rleungx mentioned this pull request Oct 23, 2023
Closed
rleungx pushed a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@JmPotato @ti-chi-bot @rleungx
scheduling/watcher, storage: integrate rule watcher with the managers (…
2284e3f 
…tikv#7213)

ref tikv#5839

Integrate rule watcher with the managers.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@rleungx rleungx rleungx approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JmPotato @lhy1024 @rleungx