Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replication_mode: use placement to determin canSync and hasMajority (#7202) (#7209) #7285

Merged
merged 2 commits into from
Oct 30, 2023
Merged

replication_mode: use placement to determin canSync and hasMajority (#7202) (#7209) #7285

merged 2 commits into from
Oct 30, 2023

Conversation

disksing
Copy link
Contributor

This is a cherry-pick of #7202 and #7222

What problem does this PR solve?

Issue Number: Close #7201

What is changed and how does it work?

  • determine canSync and hasMajority flags based on placement rule configuration.

Check List

Tests

  • Unit test

Code changes

  • Has the configuration change
    primary-replicas and dr-replicas configurations are not deprecated.

Related changes

  • Need to cherry-pick to the release branch

Release note

None.

ti-chi-bot and others added 2 commits October 30, 2023 10:46
@ti-chi-bot @disksing
replication_mode: use placement to determin canSync and hasMajority (t…
60df228 
…ikv#7202) (tikv#7209)

close tikv#7201

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: disksing <i@disksing.com>

Co-authored-by: disksing <i@disksing.com>
@ti-chi-bot @disksing
replication mode: fix wrong available store list (tikv#7222) (tikv#7224)
0f471b9 
close tikv#7221

Signed-off-by: disksing <i@disksing.com>

Co-authored-by: disksing <i@disksing.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 30, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 30, 2023
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
server/replication/replication_mode.go 82.67% <92.59%> (-0.07%) ⬇️

... and 30 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 30, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 30, 2023
@disksing
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 30, 2023

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 30, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 0f471b9

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 30, 2023
@disksing disksing merged commit 4ba0fa6 into tikv:release-6.5-20231027-v6.5.4 Oct 30, 2023
18 of 20 checks passed
@disksing disksing deleted the disksing/cp7202 branch October 30, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CabinfeverB CabinfeverB CabinfeverB approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@HunDunDM HunDunDM Awaiting requested review from HunDunDM

@JmPotato JmPotato Awaiting requested review from JmPotato

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@disksing @lhy1024 @CabinfeverB @ti-chi-bot