Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dr-autosync: canSync and hasMajority can be calculated wrong when placement rule config is complex #7201

Closed
disksing opened this issue Oct 13, 2023 · 1 comment · Fixed by #7202
Closed

dr-autosync: canSync and hasMajority can be calculated wrong when placement rule config is complex #7201

disksing opened this issue Oct 13, 2023 · 1 comment · Fixed by #7202
Assignees
@disksing
Labels
affects-6.5 affects-7.1 component/replication-mode Replication mode. severity/major type/bug The issue is confirmed as a bug.

Comments

@disksing
Copy link
Contributor

Bug Report

What did you do?

deploy a dr-autosync cluster, setup 3 voters in primary dc, 2 voters in dr dc. the tikv-servers in dr dc splits into 2 different logic zones and use placement rule to place 1 voter in each logic zone.

What did you expect to see?

kill all tikv-servers in a logic zone, the dr-autosync state should not switch to async_wait or async, as there is still 1 voter in dr zone.

What did you see instead?

the state is switched to async_wait and then async.

What version of PD are you using (pd-server -V)?

master / v6.5.5
@disksing disksing added type/bug The issue is confirmed as a bug. affects-6.5 labels Oct 13, 2023
@disksing disksing self-assigned this Oct 13, 2023
disksing added a commit to oh-my-tidb/pd that referenced this issue Oct 13, 2023
@disksing
clean up
2f6f6fd 
fix tikv#7201

Signed-off-by: disksing <i@disksing.com>
@disksing disksing mentioned this issue Oct 13, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Oct 16, 2023
@disksing
replication_mode: use placement to determin canSync and hasMajority (#…
4176c1d 
…7202)

close #7201

Signed-off-by: disksing <i@disksing.com>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Oct 16, 2023
@disksing @ti-chi-bot
This is an automated cherry-pick of tikv#7202
344a7a9 
close tikv#7201

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Oct 16, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Oct 16, 2023
@ti-chi-bot @disksing
replication_mode: use placement to determin canSync and hasMajority (#…
ba09621 
…7202) (#7209)

close #7201

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: disksing <i@disksing.com>

Co-authored-by: disksing <i@disksing.com>
disksing added a commit to oh-my-tidb/pd that referenced this issue Oct 30, 2023
@ti-chi-bot @disksing
replication_mode: use placement to determin canSync and hasMajority (t…
60df228 
…ikv#7202) (tikv#7209)

close tikv#7201

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: disksing <i@disksing.com>

Co-authored-by: disksing <i@disksing.com>
@disksing disksing mentioned this issue Oct 30, 2023
Merged
@niubell niubell mentioned this issue Nov 15, 2023
Merged
18 tasks
@niubell niubell mentioned this issue Nov 30, 2023
Merged
16 tasks
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Feb 1, 2024
@disksing @ti-chi-bot
This is an automated cherry-pick of tikv#7202
42c19a8 
close tikv#7201

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Feb 1, 2024
Closed
disksing added a commit to oh-my-tidb/pd that referenced this issue Feb 1, 2024
@ti-chi-bot @disksing
replication_mode: use placement to determin canSync and hasMajority (t…
6a00c42 
…ikv#7202) (tikv#7209)

close tikv#7201

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: disksing <i@disksing.com>

Co-authored-by: disksing <i@disksing.com>
@disksing disksing mentioned this issue Feb 18, 2024
Merged
@mayjiang0203
Copy link

/remove-label affects-7.5
This bug was fixed before v7.5 release, so remove affects-7.5.

@ti-chi-bot ti-chi-bot bot removed the affects-7.5 label Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@disksing disksing

Labels
affects-6.5 affects-7.1 component/replication-mode Replication mode. severity/major type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replication_mode: use placement to determin canSync and hasMajority oh-my-tidb/pd
3 participants
@mayjiang0203 @disksing @ti-chi-bot