Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replication: cherry-pick improvements for dr-autosync #7789

Merged
merged 5 commits into from
Feb 18, 2024
Merged

replication: cherry-pick improvements for dr-autosync #7789

merged 5 commits into from
Feb 18, 2024

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Feb 1, 2024 •
edited by rleungx
Loading

What problem does this PR solve?

cherry-pick fixes from release-6.5. including #6874 #7202 #7222

What is changed and how does it work?

Issue Number: Close #7221 #7201 #6883 #7218 close #6672

improve state replication and failover process for dr-autosync

Check List

Tests

  • Unit test

Release note

Improve state replication and failover process for dr-autosync

disksing and others added 5 commits February 1, 2024 17:06
@disksing
replication mode: tune persist file timeout (tikv#6670)
024670d 
fix tikv#6672

Signed-off-by: disksing <i@disksing.com>
@disksing
dr-autosync: move state replicate to different goroutine (tikv#6874) (t…
318ec49 
…ikv#6705)

fix tikv#6883

Signed-off-by: disksing <i@disksing.com>
@ti-chi-bot @disksing
replication_mode: use placement to determin canSync and hasMajority (t…
6a00c42 
…ikv#7202) (tikv#7209)

close tikv#7201

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: disksing <i@disksing.com>

Co-authored-by: disksing <i@disksing.com>
@ti-chi-bot @disksing
replication mode: fix wrong available store list (tikv#7222) (tikv#7224)
d8cee91 
close tikv#7221

Signed-off-by: disksing <i@disksing.com>

Co-authored-by: disksing <i@disksing.com>
@disksing
resolve conflicts
0932fdf 
Signed-off-by: disksing <i@disksing.com>
@disksing disksing added type/bugfix This PR fixes a bug. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Feb 1, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 1, 2024 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Feb 1, 2024
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx February 1, 2024 09:17
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 1, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 2, 2024 •
edited
Loading

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (6ffd9ca) 74.79% compared to head (0932fdf) 74.77%.
Report is 1 commits behind head on release-7.1.

Files Patch % Lines
server/replication/replication_mode.go 92.55% 4 Missing and 3 partials ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-7.1    #7789      +/-   ##
===============================================
- Coverage        74.79%   74.77%   -0.03%     
===============================================
  Files              411      411              
  Lines            41669    41695      +26     
===============================================
+ Hits             31166    31176      +10     
- Misses            7761     7781      +20     
+ Partials          2742     2738       -4
Flag Coverage Δ
unittests 74.77% <92.55%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 4, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 6, 2024

@TonsnakeLin: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 9, 2024
@TonsnakeLin
Copy link
Contributor

Could you merge this PR please? @disksing

@disksing
Copy link
Contributor Author

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 18, 2024

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 18, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 0932fdf

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 18, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 18, 2024
@ti-chi-bot ti-chi-bot bot merged commit e00f31e into tikv:release-7.1 Feb 18, 2024
20 checks passed
This was referenced Nov 6, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonsnakeLin TonsnakeLin TonsnakeLin approved these changes

@rleungx rleungx rleungx approved these changes

@JmPotato JmPotato JmPotato approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@disksing @TonsnakeLin @JmPotato @rleungx @ti-chi-bot