Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_mananger: deep clone resource group #7623

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Dec 27, 2023

What problem does this PR solve?

Issue Number: Close #7206

What is changed and how does it work?

resource_mananger: deep clone resource group

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Dec 27, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • bufferflies

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Dec 27, 2023
@nolouch nolouch requested review from bufferflies and CabinfeverB and removed request for disksing and rleungx December 27, 2023 07:15
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 27, 2023
Signed-off-by: nolouch <nolouch@gmail.com>
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Merging #7623 (bb9bc2d) into master (b35b0cd) will decrease coverage by 0.12%.
The diff coverage is 87.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7623      +/-   ##
==========================================
- Coverage   74.87%   74.76%   -0.12%     
==========================================
  Files         459      459              
  Lines       50647    50666      +19     
==========================================
- Hits        37921    37878      -43     
- Misses       9384     9435      +51     
- Partials     3342     3353      +11     
Flag Coverage Δ
unittests 74.76% <87.87%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 27, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 27, 2023
@nolouch
Copy link
Contributor Author

nolouch commented Dec 27, 2023

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 27, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 27, 2023

This pull request has been accepted and is ready to merge.

Commit hash: bb9bc2d

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 27, 2023
@ti-chi-bot ti-chi-bot bot merged commit ed9685a into tikv:master Dec 27, 2023
25 of 26 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #7624.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Dec 27, 2023
close tikv#7206

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #7625.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Dec 27, 2023
close tikv#7206

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@nolouch nolouch deleted the fix-copy branch December 28, 2023 02:54
ti-chi-bot bot pushed a commit that referenced this pull request Jan 2, 2024
close #7206

resource_mananger: deep clone resource group

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: nolouch <nolouch@gmail.com>

Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: nolouch <nolouch@gmail.com>
ti-chi-bot bot pushed a commit that referenced this pull request Jan 3, 2024
close #7206

resource_mananger: deep clone resource group

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: nolouch <nolouch@gmail.com>

Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PD panics when list resource-group with some resource group defined.
4 participants