Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_mananger: deep clone resource group (#7623) #7624

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7623

What problem does this PR solve?

Issue Number: Close #7206

What is changed and how does it work?

resource_mananger: deep clone resource group

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None.

close tikv#7206

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Copy link
Contributor

ti-chi-bot bot commented Dec 27, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Dec 27, 2023
@nolouch nolouch force-pushed the cherry-pick-7623-to-release-7.1 branch from 0bcc455 to 146d204 Compare January 3, 2024 04:22
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 3, 2024
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch force-pushed the cherry-pick-7623-to-release-7.1 branch from 146d204 to 705d510 Compare January 3, 2024 06:08
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 3, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 3, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (71d81a5) 74.82% compared to head (705d510) 74.79%.
Report is 1 commits behind head on release-7.1.

Files Patch % Lines
pkg/schedule/schedulers/init.go 0.00% 5 Missing ⚠️
pkg/schedule/plugin_interface.go 0.00% 3 Missing ⚠️
pkg/mcs/resource_manager/server/resource_group.go 83.33% 1 Missing and 1 partial ⚠️
pkg/mcs/resource_manager/server/token_bukets.go 84.61% 1 Missing and 1 partial ⚠️
pkg/schedule/scheduler.go 0.00% 2 Missing ⚠️
pkg/schedule/schedulers/utils.go 0.00% 2 Missing ⚠️
pkg/schedule/schedulers/evict_leader.go 0.00% 1 Missing ⚠️
pkg/schedule/schedulers/grant_leader.go 0.00% 1 Missing ⚠️
pkg/utils/logutil/log.go 0.00% 1 Missing ⚠️
pkg/utils/tempurl/check_env_linux.go 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.1    #7624      +/-   ##
===============================================
- Coverage        74.82%   74.79%   -0.03%     
===============================================
  Files              411      411              
  Lines            41632    41647      +15     
===============================================
- Hits             31151    31150       -1     
- Misses            7739     7752      +13     
- Partials          2742     2745       +3     
Flag Coverage Δ
unittests 74.79% <56.25%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nolouch
Copy link
Contributor

nolouch commented Jan 3, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jan 3, 2024

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 3, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 705d510

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 3, 2024
@ti-chi-bot ti-chi-bot bot merged commit f3a948a into tikv:release-7.1 Jan 3, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants