-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tso: fix an invalid err != nil check (#8523) #8525
tso: fix an invalid err != nil check (#8523) #8525
Conversation
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JmPotato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #8525 +/- ##
===============================================
+ Coverage 73.67% 73.76% +0.08%
===============================================
Files 437 437
Lines 48750 48749 -1
===============================================
+ Hits 35918 35960 +42
+ Misses 9772 9735 -37
+ Partials 3060 3054 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
Do we need to pick it to release-8.3? |
This is an automated cherry-pick of #8523
What problem does this PR solve?
Issue Number: close #8524.
pd/pkg/tso/keyspace_group_manager.go
Lines 1365 to 1384 in 1c1cd99
Since the
err
in the loop is a local variable, so the check at line 1382 will always be false before this fix.What is changed and how does it work?
Check List
Tests
Release note