Reduce size of EntryIndex
#206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Connor1996
reviewed
Apr 1, 2022
src/memtable.rs
Outdated
| assert_eq!(idx.index, last_index + 1); | ||
| } | ||
| last_index = Some(idx.index); | ||
| // if let Some(last_index) = last_index { |
There was a problem hiding this comment.
No need for this check because entry index doesn't store log index anymore.
| @@ -36,9 +36,9 @@ pub struct EntryIndex { | |||
| pub compression_type: CompressionType, | |||
|
|
|||
| /// The relative offset within its group of entries. | |||
| pub entry_offset: u64, | |||
| pub entry_offset: u32, | |||
There was a problem hiding this comment.
wrap ThinEntryIndex directly?
There was a problem hiding this comment.
No because ThinEntryIndex should be a private struct internal to MemTable.
Signed-off-by: tabokie <xy.tao@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
==========================================
- Coverage 96.98% 96.95% -0.04%
==========================================
Files 28 28
Lines 7602 7652 +50
==========================================
+ Hits 7373 7419 +46
- Misses 229 233 +4
Continue to review full report at Codecov.
|
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #205
Some enhancements:
EntryIndex.Size for one
EntryIndexis reduced from 64 bytes to 48 bytes (25%).stress benchmarks shows 18.7% improvement (compared to results in #207, normalized with write bandwidth):