Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace memory of MemTables #207

Merged
merged 10 commits into from
Apr 7, 2022
Merged

trace memory of MemTables #207

merged 10 commits into from
Apr 7, 2022

Conversation

tabokie
Copy link
Member

@tabokie tabokie commented Apr 1, 2022

Signed-off-by: tabokie xy.tao@outlook.com

Ref #205

Added a new method to flush internal metrics, including memory used by MemTables.

tabokie added 2 commits April 1, 2022 14:24
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie tabokie requested a review from Connor1996 April 1, 2022 07:10
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #207 (303b9c5) into master (bac5ec4) will increase coverage by 0.01%.
The diff coverage is 97.29%.

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   96.95%   96.96%   +0.01%     
==========================================
  Files          28       28              
  Lines        7652     7687      +35     
==========================================
+ Hits         7419     7454      +35     
  Misses        233      233              
Impacted Files Coverage Δ
src/engine.rs 97.13% <95.00%> (-0.04%) ⬇️
src/memtable.rs 99.13% <100.00%> (+<0.01%) ⬆️
src/metrics.rs 97.58% <100.00%> (+0.08%) ⬆️
src/consistency.rs 93.33% <0.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bac5ec4...303b9c5. Read the comment docs.

@tabokie
Copy link
Member Author

tabokie commented Apr 1, 2022

I ran a benchmark to get a baseline memory usage:

# ./target/release/stress --path /data3/re_bench --time 60 --regions 1000 --write-threads 1 --purge-interval 0 --compact-count 0 --write-without-sync
Memory usage: 8003MiB
Throughput(QPS) = 30061.84
Latency(μs) min = 8, avg = 17.72, p50 = 15, p90 = 28, p95 = 33, p99 = 48, p99.9 = 76, max = 5827
Fairness = 100.0%
Write Bandwidth = 22.5MiB/s

@tabokie tabokie mentioned this pull request Apr 1, 2022
tabokie added 2 commits April 1, 2022 16:29
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
src/engine.rs Outdated Show resolved Hide resolved
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie tabokie requested review from Connor1996 April 7, 2022 03:44
tabokie added 5 commits April 7, 2022 12:22
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
This reverts commit 16b933b.

Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tabokie tabokie merged commit 2fe0c36 into tikv:master Apr 7, 2022
@tabokie tabokie deleted the memory-trace branch April 7, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants