Have CI do a fmt as well #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoverbear
force-pushed
the
add-rustfmt
branch
2 times, most recently
from
0f3d14c
to
238b88f
Compare
|
This is failing due to the Rust version being too old to have the |
Hoverbear
force-pushed
the
add-rustfmt
branch
3 times, most recently
from
ccbe15c
to
eec1d60
Compare
BusyJay
reviewed
May 9, 2018
.travis.yml
Outdated
| install: | ||
| - export PATH="$PATH:$HOME/.cargo/bin" | ||
| - rustup component add rustfmt-preview |
There was a problem hiding this comment.
What if the format is different from stable channel?
There was a problem hiding this comment.
👍 Great catch, you're totally right. We should just run rustfmt on stable.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we're not using
rustfmtvia CI for Raft, and we should be! This configures it.