Update rust & clippy on CI #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
siddontang
reviewed
Apr 23, 2018
src/log_unstable.rs
Outdated
| @@ -74,22 +74,25 @@ impl Unstable { | |||
| // is any. | |||
| pub fn maybe_term(&self, idx: u64) -> Option<u64> { | |||
| if idx < self.offset { | |||
| if self.snapshot.is_none() { | |||
| return None; | |||
| match self.snapshot.as_ref() { | |||
There was a problem hiding this comment.
Seem we used a Go style here before, and maybe this is a better Rust style.
PTAL @BusyJay
There was a problem hiding this comment.
I think less indent is better is a common sense. Besides using ? is better here.
There was a problem hiding this comment.
Using ? here aggravates the borrow checker.
There was a problem hiding this comment.
aggravate? you mean it will reduce the performance?
There was a problem hiding this comment.
It prevents compiling.
There was a problem hiding this comment.
There was a problem hiding this comment.
Didn't see this, reflected.
|
LGTM PTAL @BusyJay |
BusyJay
previously approved these changes
May 9, 2018
Hoverbear
force-pushed
the
update-rust-clippy-on-ci
branch
from
53f23c2
to
e946b20
Compare
|
please fix the conflict @Hoverbear |
Hoverbear
force-pushed
the
update-rust-clippy-on-ci
branch
from
e946b20
to
1beea8c
Compare
|
This was closed as part of #55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #55 the Nightly CI runs are failing due to using an old Rust version. With tikv/tikv#2922 merged we should bump this.
This PR updates the Rust and clippy version, and resolves the new clippy warnings.