Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port patch of tikv to 6.25.3 #266

Closed
wants to merge 26 commits into from

Conversation

Little-Wallace
Copy link

No description provided.

Little-Wallace and others added 10 commits November 9, 2021 14:31
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
* add option to disable write stall

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Add listener for subcompaction, only called when there are actually multiple subcompactions executed in parallel.

Signed-off-by: tabokie <xy.tao@outlook.com>
@yiwu-arbug
Copy link
Collaborator

Looking good overall.

Any changes worth mentioning, aside from copying over the code from 6.4.tikv branch? Asking because it is hard to see if there's any change.

As per encryption and file inspected env, we may consider move to the newer FileSystem API. But we are good for now.

@yiwu-arbug
Copy link
Collaborator

There are some more patches need to migrate:
96d7d16
906258c
979a985
bf9fa0e
953f8b2
7e6c07d
0d1ac74
afa47b6
6b97c05
f236fe4

There might be more. But it is okay to have them in separate PR.

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you list all the commits that we patched and make a checkbox list for them to see if any is missing?

hicqu and others added 5 commits November 12, 2021 11:30
* add range for compaction filter context

Signed-off-by: qupeng <qupeng@pingcap.com>
I want to use format of rocksdb::WriteBatch to encode key-value pairs of TiKV, and I need an more effective method to copy data from Entry to WriteBatch directly so that I could avoid CPU cost of decode.

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Little-Wallace and others added 7 commits November 25, 2021 15:28
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: liuwei <liuwei@liuweideMacBook-Pro.local>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

Support write multiple WriteBatch into RocksDB together. These WriteBatch will be assigned sequence number in order and pushed into queue. If a thread is waiting for some state, it could steal some job from work queue.
* perform like normal pipelined write

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@ethercflow
Copy link
Member

Hi @Little-Wallace Would you please also pick facebook@b0c5ecd?
We hope we can online config max_subcompactions thanks!

@tabokie
Copy link
Member

tabokie commented May 10, 2022

Superseded by #277

@tabokie tabokie closed this May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants