Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight edits to intro caggs sections #2602

Merged
merged 9 commits into from
Aug 28, 2023
Merged

Slight edits to intro caggs sections #2602

merged 9 commits into from
Aug 28, 2023

Conversation

Loquacity
Copy link
Contributor

@Loquacity Loquacity commented Aug 7, 2023

Description

These edits kill a couple of birds with one stone:

  • The aggregation concept sections of the GSG were a little confusing, so it hopefully clears up some of that confusion
  • We don't tend to mention that caggs are based on hypertables, so this detail has been added

Links

Partial: https://github.com/timescale/docs-private/issues/170

Writing help

For information about style and word usage, see the style guide

Review checklists

Reviewers: use this section to ensure you have checked everything before approving this PR:

Subject matter expert (SME) review checklist

  • Is the content technically accurate?
  • Is the content complete?
  • Is the content presented in a logical order?
  • Does the content use appropriate names for features and products?
  • Does the content provide relevant links to further information?

Documentation team review checklist

  • Is the content free from typos?
  • Does the content use plain English?
  • Does the content contain clear sections for concepts, tasks, and references?
  • Have any images been uploaded to the correct location, and are resolvable?
  • If the page index was updated, are redirects required
    and have they been implemented?
  • Have you checked the built version of this content?

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Allow 10 minutes from last push for the staging site to build. If the link doesn't work, try using incognito mode instead. For internal reviewers, check web-documentation repo actions for staging build status. Link to build for this PR: http://docs-dev.timescale.com/docs-caggs-editing-lana

Copy link
Contributor

@Rajakavitha1 Rajakavitha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

_partials/_caggs-intro.md Outdated Show resolved Hide resolved
Loquacity and others added 2 commits August 7, 2023 18:30
Co-authored-by: Rajakavitha Kodhandapani <krajakavitha@gmail.com>
Signed-off-by: Lana Brindley <github@lanabrindley.com>
Copy link
Contributor

@iroussos iroussos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Loquacity, great initial update!

I added a few thoughts / comments - not everything is a clocking comment, I just added a bunch of thoughts in there; yours to think about where things would be better shown or if they are really needed.

_partials/_caggs-intro.md Show resolved Hide resolved
_partials/_caggs-intro.md Outdated Show resolved Hide resolved
_partials/_caggs-intro.md Outdated Show resolved Hide resolved
getting-started/aggregation.md Outdated Show resolved Hide resolved
@Loquacity Loquacity mentioned this pull request Aug 8, 2023
11 tasks
Copy link
Contributor

@Rajakavitha1 Rajakavitha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Loquacity Loquacity merged commit 49581f1 into latest Aug 28, 2023
2 checks passed
@Loquacity Loquacity deleted the caggs-editing-lana branch August 28, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants