Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSG Further edits - Part 1 #2610

Merged
merged 21 commits into from
Sep 4, 2023
Merged

GSG Further edits - Part 1 #2610

merged 21 commits into from
Sep 4, 2023

Conversation

Loquacity
Copy link
Contributor

@Loquacity Loquacity commented Aug 8, 2023

MERGE #2602 FIRST!!

Description

  • Services: make connection more prominent
  • Queries: Add time_bucket query
  • Aggregation: title change and remove average procedure

Links

Fixes https://github.com/timescale/docs-private/issues/170

Writing help

For information about style and word usage, see the style guide

Review checklists

Reviewers: use this section to ensure you have checked everything before approving this PR:

Subject matter expert (SME) review checklist

  • Is the content technically accurate?
  • Is the content complete?
  • Is the content presented in a logical order?
  • Does the content use appropriate names for features and products?
  • Does the content provide relevant links to further information?

Documentation team review checklist

  • Is the content free from typos?
  • Does the content use plain English?
  • Does the content contain clear sections for concepts, tasks, and references?
  • Have any images been uploaded to the correct location, and are resolvable?
  • If the page index was updated, are redirects required
    and have they been implemented?
  • Have you checked the built version of this content?

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Allow 10 minutes from last push for the staging site to build. If the link doesn't work, try using incognito mode instead. For internal reviewers, check web-documentation repo actions for staging build status. Link to build for this PR: http://docs-dev.timescale.com/docs-gsg-improvements-part1-lana

@Loquacity Loquacity changed the title Add collapsibles to services. let's see. GSG Further edits - Part 1 Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Site build failed. For Timescale internal contributors, check the logs in the web-documentation repo to see the failure reason. For help, contact the docs team.

@github-actions
Copy link

Site build failed. For Timescale internal contributors, check the logs in the web-documentation repo to see the failure reason. For help, contact the docs team.

@Loquacity Loquacity marked this pull request as ready for review August 10, 2023 06:13
@Loquacity Loquacity requested review from a team, noctarius and jamessewell August 14, 2023 07:43
Copy link
Contributor

@Rajakavitha1 Rajakavitha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

getting-started/services.md Outdated Show resolved Hide resolved
Co-authored-by: Rajakavitha Kodhandapani <krajakavitha@gmail.com>
Signed-off-by: Lana Brindley <github@lanabrindley.com>
@Loquacity
Copy link
Contributor Author

This is ready to merge now, so happy for you to review please! 💖

Copy link
Contributor

@Rajakavitha1 Rajakavitha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@Loquacity Loquacity merged commit 25e86ca into latest Sep 4, 2023
2 checks passed
@Loquacity Loquacity deleted the gsg-improvements-part1-lana branch September 4, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants