This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Add a simple tracing setup to the docker-compose #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesGuthrie
requested review from
bitwalker,
niksajakovljevic and
VineethReddy02
and removed request for
a team and
niksajakovljevic
bitwalker
approved these changes
Jan 12, 2022
|
I'm gonna wait for some tracing support in Promscale and then use that as a source of traces instead of |
JamesGuthrie
force-pushed
the
jg/add-tracing-to-docker
branch
2 times, most recently
from
b3cdcec to
b450cfc
Compare
JamesGuthrie
force-pushed
the
jg/add-tracing-to-docker
branch
2 times, most recently
from
aa566cd to
01b00b4
Compare
|
FYI I have added a config on top of ante's open PR here: #1052. Once that is merged I will rebase and un-draft this PR. |
When running docker-compose down, it would invariably hang on Prometheus until it gets killed. This is because Promscale would be stopped before Prometheus, and Prometheus would be unable to close its remote_write backend.
JamesGuthrie
force-pushed
the
jg/add-tracing-to-docker
branch
from
01b00b4 to
f330ed2
Compare
antekresic
approved these changes
Feb 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a tracing configuration to our docker-compose, leveraging Promscale's trace output.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: