This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Initial metric ingest tracing instrumentation #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antekresic
added
the
Performance
antekresic
requested review from
Harkishen-Singh,
niksajakovljevic and
a team
as code owners
antekresic
requested review from
cevian
and removed request for
niksajakovljevic
antekresic
force-pushed
the
ingest-tracing
branch
3 times, most recently
from
ffc686e to
b0cf933
Compare
jgpruitt
reviewed
Jan 13, 2022
jgpruitt
approved these changes
Jan 13, 2022
Harkishen-Singh
approved these changes
Jan 14, 2022
2 tasks
cevian
suggested changes
Jan 14, 2022
antekresic
force-pushed
the
ingest-tracing
branch
from
b0cf933 to
3897ceb
Compare
cevian
approved these changes
Jan 24, 2022
This change is the first step into tracing instrumentation on Promscale using OpenTelemetry tracing libraries. Right now, its limited to metric ingest path and only supports exporting traces to Jaeger. Rest of the codebase (i.e. query path), as well as adding more exporting support, will be covered in future PRs.
This is an optimization to remove the need to fetch metric ID and table name when storing new series data since we already fetch this info in a prior step of the process.
antekresic
force-pushed
the
ingest-tracing
branch
from
3897ceb to
507fb2a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is the first step into tracing instrumentation on Promscale
using OpenTelemetry tracing libraries. Right now, its limited to metric
ingest path and only supports exporting traces to Jaeger. Rest of the
codebase (i.e. query path), as well as adding more exporting support,
will be covered in future PRs.
Closes #1004
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: