Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs on MethodInstances #8

Merged
merged 2 commits into from
Dec 31, 2022
Merged

Add docs on MethodInstances #8

merged 2 commits into from
Dec 31, 2022

Conversation

timholy
Copy link
Owner

@timholy timholy commented Dec 27, 2022

No description provided.

@timholy
Copy link
Owner Author

timholy commented Dec 27, 2022

Odd...CI passed (for nightly) on #4, #5, and #6. It also works locally. I wonder what went wrong here? Back then it wasn't testing the .so format, but it seems to be doing so now (rather quick nightly build!) so something has definitely changed.

@timholy timholy closed this Dec 29, 2022
@timholy timholy reopened this Dec 29, 2022
@timholy
Copy link
Owner Author

timholy commented Dec 29, 2022

Still failing. The issue is that Base.ocachefile_from_cachefile(path) is not returning the correct path to the .so cache file. From the debug commit log:

path = "/home/runner/.julia/compiled/v1.10/Colors/NKjaT_t9hk1.ji"
isfile(path) = true
opath = "/home/runner/.julia/compiled/v1.10/Colors/NKjaT_t9hk1.so"
isfile(opath) = false

Any ideas, @vchuravy?

@timholy
Copy link
Owner Author

timholy commented Dec 29, 2022

I should say it works fine locally, this seems to be a CI-specific issue.

@vchuravy
Copy link
Collaborator

Are you sure that code-coverage is not turned on?

@IanButterworth
Copy link
Collaborator

julia-runtest defaults to coverage on, so it should be based on the test yml

@timholy
Copy link
Owner Author

timholy commented Dec 31, 2022

Fixed in #11

@timholy timholy merged commit 5d9d277 into main Dec 31, 2022
@timholy timholy deleted the teh/docs branch December 31, 2022 13:29
@timholy
Copy link
Owner Author

timholy commented Dec 31, 2022

Registration is underway, but apparently JuliaRegistrator is not ready for the weakdeps world. There may be a bit of a delay.

Until then, we should periodically check and see if https://timholy.github.io/PkgCacheInspector.jl/dev/ eventually deploys (it hasn't yet at the time of this writing). The README links to stable, which won't appear until registration goes through.

@timholy
Copy link
Owner Author

timholy commented Jan 1, 2023

@IanButterworth
Copy link
Collaborator

No idea

@timholy
Copy link
Owner Author

timholy commented Jan 3, 2023

Fixed, problem was in the Pages setting:
image

Under Branch it needs to be gh-pages and /(root)

@timholy
Copy link
Owner Author

timholy commented Jan 3, 2023

Fix is thanks to @mortenpi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants