Skip to content

Commit

Permalink
Respond to comments
Browse files Browse the repository at this point in the history
  • Loading branch information
timl3136 committed Feb 26, 2025
1 parent 143b2a4 commit efe9cd2
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 17 deletions.
2 changes: 1 addition & 1 deletion service/history/execution/context.go
Original file line number Diff line number Diff line change
Expand Up @@ -1401,7 +1401,7 @@ func (c *contextImpl) Size() uint64 {
size += 512 // MetricsClient estimation
size += 256 // ExecutionManager estimation
size += 8 // Mutex
size += c.mutableState.GetEstimatedMutableStateSize()
size += c.mutableState.Size()
size += 8 // stats pointer

size += 18 * 8 // 18 function pointers with 8 bytes each
Expand Down
2 changes: 1 addition & 1 deletion service/history/execution/mutable_state.go
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,6 @@ type (
GetHistorySize() int64
SetHistorySize(size int64)

GetEstimatedMutableStateSize() int
Size() int
}
)
2 changes: 1 addition & 1 deletion service/history/execution/mutable_state_builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -1595,7 +1595,7 @@ func (e *mutableStateBuilder) SetHistorySize(size int64) {
e.executionStats.HistorySize = size
}

func (e *mutableStateBuilder) GetEstimatedMutableStateSize() int {
func (e *mutableStateBuilder) Size() int {
// TODO: To be implemented
return 0
}
Expand Down
28 changes: 14 additions & 14 deletions service/history/execution/mutable_state_mock.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit efe9cd2

Please sign in to comment.