Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Edit Config UI and Cleanup UI #199

Merged
merged 105 commits into from
Mar 25, 2019
Merged

Rewrite Edit Config UI and Cleanup UI #199

merged 105 commits into from
Mar 25, 2019

Conversation

timmo001
Copy link
Owner

@timmo001 timmo001 commented Jan 19, 2019

Description

Rewrites config UI to integrate with main UI, instead of using a dynamically created form dialog.

Also rewrites a lot of the UI.

Related issues this fixes

Fixes: #195
Fixes: #218
Fixes: #225
Fixes: #226
Fixes: #227

Todo

  • Make all cards clickable when editing
  • Add / Edit pages setup
  • Add / Edit cards setup
  • Get pages to add and save
  • Get cards to add and save
  • Config should only change on save
  • Fix / handle config ui slow loading
  • Add a card with a + symbol on each group
  • Fix config change on edit card
  • Update card on save
  • Add a way to delete
  • Add a way to add groups
  • Add config for themes
  • Add config for header
  • Fix nested object in cards for custom sizes
  • Move card preview to left for larger screens
  • Find out where null array items are being generated. Perhaps add a cleanup to configChange
  • Delete cards in deleted page and move groups to new page. Either this or rework the pages to use names instead (dropdown in config). This would require migration or a release note, but would fix Page assignment - To add to page 1 you need to assign to page 2  #226.
  • Check all previews work
  • Cleanup all debugs and useless comments
  • Documentation updated

Future Additions (Create issues after merge)

  • Add a way to reorder pages
  • Add a way to reorder groups
  • Add a way to reorder cards
  • Built-in JSON editor
  • Get entities for hass cards in the editor (autosuggestions)
  • Validation

Checklist

  • Change has been tested and works on my device(s).
  • Linters have been run.
  • I am ready to merge.

Repository owner deleted a comment from houndci-bot Jan 19, 2019
Repository owner deleted a comment from houndci-bot Jan 19, 2019
Repository owner deleted a comment from houndci-bot Jan 19, 2019
Repository owner deleted a comment from houndci-bot Jan 19, 2019
@timmo001 timmo001 self-assigned this Jan 20, 2019
@timmo001 timmo001 force-pushed the rewrite-config-ui branch 2 times, most recently from bdc2ccd to f5ab27c Compare January 27, 2019 10:52
@timmo001 timmo001 changed the title WIP: Rewrite Edit Config UI WIP: Rewrite Edit Config UI and Cleanup UI Jan 27, 2019
src/Components/Main.js Outdated Show resolved Hide resolved
@timmo001 timmo001 force-pushed the rewrite-config-ui branch from 93bd847 to f444b67 Compare March 25, 2019 16:50
@timmo001 timmo001 changed the title WIP: Rewrite Edit Config UI and Cleanup UI Rewrite Edit Config UI and Cleanup UI Mar 25, 2019
@timmo001 timmo001 merged commit 1080691 into master Mar 25, 2019
@timmo001 timmo001 deleted the rewrite-config-ui branch March 25, 2019 20:24
@timmo001 timmo001 mentioned this pull request Mar 25, 2019
8 tasks
@ghost
Copy link

ghost commented Apr 25, 2019

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.