Add DeseasonalityTransform
#1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-1307--etna-docs.netlify.app |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1307 +/- ##
==========================================
+ Coverage 88.65% 88.66% +0.01%
==========================================
Files 196 197 +1
Lines 12048 12127 +79
==========================================
+ Hits 10681 10753 +72
- Misses 1367 1374 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Mr-Geekman
suggested changes
Jul 4, 2023
| name of processed column | ||
| period: | ||
| size of seasonality | ||
| model: |
There was a problem hiding this comment.
We can do this by using enum. Value checking will be made there.
tests/test_transforms/test_decomposition/test_deseasonal_transform.py
Outdated
Show resolved
Hide resolved
tests/test_transforms/test_decomposition/test_deseasonal_transform.py
Outdated
Show resolved
Hide resolved
tests/test_transforms/test_decomposition/test_deseasonal_transform.py
Outdated
Show resolved
Hide resolved
Mr-Geekman
suggested changes
Jul 5, 2023
tests/test_transforms/test_decomposition/test_deseasonal_transform.py
Outdated
Show resolved
Hide resolved
Mr-Geekman
reviewed
Jul 6, 2023
Mr-Geekman
approved these changes
Jul 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Closing issues
Closes #680.