Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail install script when read-only filesystem is enabled #1243

Closed
mtlynch opened this issue Dec 29, 2022 · 0 comments · Fixed by #1250
Closed

Fail install script when read-only filesystem is enabled #1243

mtlynch opened this issue Dec 29, 2022 · 0 comments · Fixed by #1250
Assignees
@cghague
Labels
enhancement New feature or request

Comments

@mtlynch
Copy link
Contributor

mtlynch commented Dec 29, 2022 •
edited
Loading

If the user enabled the read-only filesystem and then performs an update, the system will reboot and go back to the pre-update state, which is not what the user wants or expects.

We should add a check for the overlay filesystem in ./bunder/bundle/install that aborts the script with a failing exit code if the overlay filesystem is turned on. It should print a message to stderr telling the user that their read-only filesystem is enabled, and they can disable it with the instructions on the website: https://tinypilotkvm.com/faq/read-only-filesystem#disabling-the-read-only-filesystem

This issue is related to #1206, but this is a block in the install script itself, whereas that bug is a check before the update can even be initiated. The two complement each other, but this bug is higher priority because it will block both UI and terminal-based install flows.
@mtlynch mtlynch added the enhancement New feature or request label Dec 29, 2022
@cghague cghague self-assigned this Dec 29, 2022
@cghague cghague mentioned this issue Jan 4, 2023
Merged
cghague added a commit that referenced this issue Jan 5, 2023
@cghague
Modify install script to fail if the read-only filesystem is enabled (#…
289b85a 
…1250)

Resolves #1243 by modifying the install script to fail if the read-only
filesystem is enabled.
<a data-ca-tag
href="https://codeapprove.com/pr/tiny-pilot/tinypilot/1250"><img
src="https://codeapprove.com/external/github-tag-allbg.png" alt="Review
on CodeApprove" /></a>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cghague cghague

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modify install script to fail if the read-only filesystem is enabled tiny-pilot/tinypilot
2 participants
@mtlynch @cghague