Modify install script to fail if the read-only filesystem is enabled #1250
Conversation
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
⏳ Approval Pending (1 unresolved comments)
Approval will be granted automatically when all comments are resolved
LGTM, thanks!
In: bundler/bundle/install:
> Line 54
echo 'See https://tinypilotkvm.com/faq/read-only-filesystem for details.' >&2
Can we link to the exact heading?
https://tinypilotkvm.com/faq/read-only-filesystem#disabling-the-read-only-filesystem
👀 @cghague it's your turn please take a look
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
In: bundler/bundle/install:
> Line 54
echo 'See https://tinypilotkvm.com/faq/read-only-filesystem for details.' >&2
I had that at first but the extra text takes the link to 84 characters which is slightly over the typical terminal width. The resulting line break doesn't look great and makes copying it from a terminal window awkward. Would you still like me to make this change?
👀 @mtlynch it's your turn please take a look
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
✔️ Approved
LGTM, thanks!
In: bundler/bundle/install:
> Line 54
echo 'See https://tinypilotkvm.com/faq/read-only-filesystem for details.' >&2
Oh good point. Leave as-is then.
👀 @cghague it's your turn please take a look
cghague
deleted the
1243-fail-install-script-when-read-only-filesystem-is-enabled
branch
Resolves #1243 by modifying the install script to fail if the read-only filesystem is enabled.
