Add js sdk folder to fish-tank #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colriot
requested changes
Oct 29, 2024
| @@ -5,7 +5,7 @@ on: | |||
| types: [opened, synchronize, reopened] | |||
|
|
|||
| jobs: | |||
| pre-commit: | |||
| python-pre-commit: | |||
There was a problem hiding this comment.
Why do we call this pre-commit if it's already a PR-time check?
| node-version: "20" | ||
|
|
||
| - name: Install dependencies | ||
| working-directory: ./javascript-sdk |
There was a problem hiding this comment.
we should just call the folder js. it's not SDK, and JS a pretty widespread short name
| await page.keyboard.press('Enter'); | ||
|
|
||
| // Extract data using AgentQL API's queryData() method | ||
| const data = await page.queryData(PRODUCT_DATA_QUERY); |
paveldudka
previously requested changes
Oct 29, 2024
There was a problem hiding this comment.
please have 2 separate precommit flows and add filtering for the path. Otherwise both python and JS flows will run regardless of where the change was made. I.e. we don't want to run JS precommit if python code was changed
There was a problem hiding this comment.
Understood! I will update it in the upcoming PRs. For now, I will leave as it is so people could merge into this branch.
rachelnabors
approved these changes
Oct 29, 2024
* collect pricing data example * update lint * Update javascript-sdk/examples/collect-pricing-data/README.md Co-authored-by: R L Nabors <rachelnabors@users.noreply.github.com> --------- Co-authored-by: R L Nabors <rachelnabors@users.noreply.github.com>
* Add js example for list query usage * lint * Address security concerns * lint * Add review comments * Lint * Lint
…saw successful reload (#84)
* Add close-popup files * Format * Update example * format * Update javascript-sdk/examples/close-popup/README.md * Update --------- Co-authored-by: R L Nabors <rachelnabors@users.noreply.github.com>
* js example cookie * readme * link * . * agentql env key * Update javascript-sdk/examples/close-cookie-dialog/README.md * remove api key setup --------- Co-authored-by: R L Nabors <rachelnabors@users.noreply.github.com>
* Add examples * Format * Update javascript-sdk/examples/log-into-sites/README.md * Update --------- Co-authored-by: R L Nabors <rachelnabors@users.noreply.github.com>
* Update * Update * Update * Update * Update * Update * Update * Update --------- Co-authored-by: R L Nabors <rachelnabors@users.noreply.github.com>
|
TODO:
|
* Add js headless browser script
* Add example script * Add readme * Fix await * Fix format * Fix lint error * Fix nits
* Add xpath application example * Add extra comment * linting * `python` -> `Javascript`
* Add wait for entire page to load example script * Add `await` * `.py` -> `.js`
* submit form js example * changes * ran lint * changes
…ish-tank into add_js_sdk_examples_folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added JS SDK folder to fish-tank repo and updated necessary VSCode settings as well as CI check for JS code.