-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xpath application example #92
Add xpath application example #92
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great! Please address two nits before merging
npm install playwright-dompath | ||
``` | ||
|
||
- Save this python file locally as **xpath.js** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python -> Javascript
await browser.close(); | ||
} | ||
|
||
main(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
main()
needs to be awaited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
False alarm, this should not be awaited
* Add js sdk folder to fish-tank * Update formatting * Add placeholder files * Update naming of the file * Add one more example * kate/tf 3913 application collect ecommerce pricing data (#81) * collect pricing data example * update lint * Update javascript-sdk/examples/collect-pricing-data/README.md Co-authored-by: R L Nabors <rachelnabors@users.noreply.github.com> --------- Co-authored-by: R L Nabors <rachelnabors@users.noreply.github.com> * Add js example for list query usage (#83) * Add js example for list query usage * lint * Address security concerns * lint * Add review comments * Lint * Lint * add save / load authenticated session js sdk example. ran script and saw successful reload (#84) * Add close-popup files (#76) * Add close-popup files * Format * Update example * format * Update javascript-sdk/examples/close-popup/README.md * Update --------- Co-authored-by: R L Nabors <rachelnabors@users.noreply.github.com> * Close cookie popup js sdk (#77) * js example cookie * readme * link * . * agentql env key * Update javascript-sdk/examples/close-cookie-dialog/README.md * remove api key setup --------- Co-authored-by: R L Nabors <rachelnabors@users.noreply.github.com> * Add log-into-sites examples (#79) * Add examples * Format * Update javascript-sdk/examples/log-into-sites/README.md * Update --------- Co-authored-by: R L Nabors <rachelnabors@users.noreply.github.com> * Compare Product Prices Example (#78) * Update * Update * Update * Update * Update * Update * Update * Update --------- Co-authored-by: R L Nabors <rachelnabors@users.noreply.github.com> * Add headless browser script (#85) * Add js headless browser script * Add Getting Started YT script (#90) * Add wait for entire page to load example script * Js stealth mode example (#80) * Add example script * Add readme * Fix await * Fix format * Fix lint error * Fix nits * Add xpath application example (#92) * Add xpath application example * Add extra comment * linting * `python` -> `Javascript` * Added javascript sentiment analysis script (#94) * Add wait for entire page to load example script (#95) * Add wait for entire page to load example script * Add `await` * `.py` -> `.js` * submit form js example (#89) * submit form js example * changes * ran lint * changes * Add get_by_prompt example * Fix formatting * add interact with existing browser example * Update interact with existing browser example * address comments & fix examples --------- Co-authored-by: Kate Zhang <54541538+KateZhang98@users.noreply.github.com> Co-authored-by: R L Nabors <rachelnabors@users.noreply.github.com> Co-authored-by: Urvish Thakker <141964033+thakkerurvish@users.noreply.github.com> Co-authored-by: Mark Peng <mark@tinyfish.io> Co-authored-by: Suveen Ellawela <suveen@tinyfish.io> Co-authored-by: Aaron Tan <157438789+aarontantf@users.noreply.github.com> Co-authored-by: Jin Yang <157438770+jinyangTF@users.noreply.github.com> Co-authored-by: Zachary Lyon <zachary@lyonfamily.org> Co-authored-by: Sergey Ryabov <944361+colriot@users.noreply.github.com> Co-authored-by: Julius Gambe <gambe@tinyfish.io> Co-authored-by: Josh Kung <josh@tinyfish.io>
No description provided.