This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
upstream update #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e.proto. Implement ParallelRunner and Checkpointer. Create a simple test for ParallelRunner.
workflow. Complete the unit test and E2E test for happy path.
unit test to verify this function. Implemented Horizontal Resharding workflow and tested in unit test and e2e test for the happy path.
It's just exposing the library methods into a binary, and using it in python tests.
And a unit test that validates it.
With tests. Also, the server side needs to not use a buffer read for the first handshake packet, so it doesn't buffer TLS negociation packets as well.
for change on node.go in workflow folder.
This happened only when shards were included as well.
Upon initial rebuild for a new keyspace, also call RebuildVSchema
Created the Code enum to match grpc error codes, and renamed all previous error codes to not have a name clash. Also renamed The older field to LegacyCode.
vtrpcpb.ErrorCode is used only at the grpc boundary for legacy purposes.
* Renamed old error names to legacy. * Changed all clients to handle legacy and new codes. * Added tests for the conversions.
Tests were using fatal/retry style error handling. Those are now updated to use vtrpcpb.Code. Also fixed error code priorities in the error aggregation function. BUG=32851872
All VTGate error types have been consolidated to use vterrors. Also, /debug/vars error reporting has been consolidated. Theres is now only one error var, but it has a fourth category which is the Code. We can consider dropping one of the other categories as the number of combinations may be too high.
The wrapper functionality now takes over the retry decision because it's better suited to make it. For example, a streaming query should not be retried if it's already sent results.
Also delete TabletError
vtgate/buffer: Fix bug that keyspaces were not logged at startup.
horizontal resharding workflow. First round comments resolved. (addressing race condition warnings)
workflow: resharding workflow: Implement checkpointing.
This is a follow-up fix for vitessio#2495. We were not able to fix Yipei's workstation such that it would use the same protobuf generator as Travis and our setups does. Therefore, I'm re-generating the files separately on my machine.
proto: Regenerate protobuf files.
I've also regenerated all protobuf files. Note that the new version has added getters for primitive types. Do NOT use these getters and instead always use the field names instead.
Cipher must be a legal UTF8 string.
It makes more sense for strict mode check to be moved to QueryEngine because it's the one that depends on that property.
Also, export only Engine from messager. The rest are all inernal.
* Created vttablet directory to hold tabletserver and tabletmanager. * scaffolding packages like grpc and interfaces are under vttablet. * tabletserver and tabletmanager have subdirs, but only on packages they depend on.
To use an internal data structure (vs the proto structure), so we can get more information from RBR events if available. Filling in the table name when available in RBR event, and using it in table filter.
User can control through UI for running a canary task, then running the remaining tasks. Create unit tests and manually test the UI in e2e test environment.
Extra bonus: it actually passes.
Rbr: more work.
|
👍 |
rafael
pushed a commit
that referenced
this pull request
Sep 14, 2017
BUG=65416566 When vttablet tries to send a new message to vtgate and receives EOF error, vttablet considers that as a real error and does an exponential back-off for retries. That means when vttablet sits idle for a long time (there are no new messages), and all clients reopened their MessageStream RPCs (which means a lot of dead RPCs due to point #1 above), then when new message arrives vttablet will receive a lot of EOF errors while it tries to send the message over dead RPCs. Due to exponential back-off real delivery of this message will be delayed significantly. If a send returns EOF, the sender does not postpone the messages. Instead, it turns on the messages pending flag and returns. This will cause the poller to be woken up by the send loop as soon as it gets through the cache.
rafael
pushed a commit
that referenced
this pull request
Jan 12, 2018
rafael
pushed a commit
that referenced
this pull request
Jun 21, 2018
rafael
pushed a commit
that referenced
this pull request
Jul 3, 2019
vtbackup: Clean up and add policy enforcement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to ca81fda (latest as of 2017-03-17).