This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
[cherry pick] Apply GRPC error processing change from upstream #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
[java] bump java version to 7.0 for release-7.0
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…port Settings tweak backport
…ment Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Do not add tablet that is going down. Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Add diagnostic logging to healthcheck.
Backport: Make sure lookup vindexes are queryable inside transaction
backport vitessio#6514 to 7.0 release branch
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
… failure Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Backport of 6522 to release 7.0
…tessio#6546) * tablet_picker: keep trying to find a tablet until context expires Signed-off-by: deepthi <deepthi@planetscale.com> * tablet_picker: keyspace/shard/cells must be provided Signed-off-by: deepthi <deepthi@planetscale.com> * tablet picker: return ks/cell/shard in test result for TestShardMigrateMainflow Signed-off-by: Rohit Nayak <rohit@planetscale.com> * tablet picker: fix wrangler tests by choosing a valid source per-test Signed-off-by: Rohit Nayak <rohit@planetscale.com> * tablet picker: fix worker and testlib tests Signed-off-by: Rohit Nayak <rohit@planetscale.com> * tablet_picker: gofmted Signed-off-by: Rohit Nayak <rohit@planetscale.com> * tablet picker: fix test races Signed-off-by: Rohit Nayak <rohit@planetscale.com> * tablet picker: gofmt Signed-off-by: Rohit Nayak <rohit@planetscale.com> * tablet picker: gofmt Signed-off-by: Rohit Nayak <rohit@planetscale.com> * healthcheck: cleanup test code where we were setting the same flag twice Signed-off-by: deepthi <deepthi@planetscale.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com>
Backport: HandleSet in executor to handle multiple settings in single set statement
…t in dml query Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Backport: Turn off schema tracker by default
Backport: VDiff: fix panic for tables with a unicode_loose_md5 vindex
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
[Backport] Fix reserved connection in autocommit mode on DML vitessio#6748
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Backport vitessio#6758 operator precedence must take associativity into consideration
Signed-off-by: Andres Taylor <andres@planetscale.com>
…esired database is present Signed-off-by: deepthi <deepthi@planetscale.com>
…est, print command output on failure Signed-off-by: deepthi <deepthi@planetscale.com>
Backport: checkNoDB should not require tables to be present
sort tabledefinitions before comparing them
…al merge commit Update parser to support `SHOW DATABASES LIKE '%nnn%' Signed-off-by: Andrew Mason <amason@slack-corp.com> Add VITESS_KEYSPACES and KEYSPACES to keyword variables Signed-off-by: Andrew Mason <amason@slack-corp.com> Use sqlparser types instead of raw strings Signed-off-by: Andrew Mason <amason@slack-corp.com> Add parser support for showing filtered tablets/shards Signed-off-by: Andrew Mason <amason@slack-corp.com> Include filters Signed-off-by: Andrew Mason <amason@slack-corp.com> Add support in the executor for `SHOW VITESS_SHARDS LIKE '...'` Signed-off-by: Andrew Mason <amason@slack-corp.com> Add support for filtering tablets by hostname Signed-off-by: Andrew Mason <amason@slack-corp.com> Add log line to avoid deadbranch check, remove unused function Signed-off-by: Andrew Mason <amason@slack-corp.com> Update formatting for SHOW, add test cases Signed-off-by: Andrew Mason <amason@slack-corp.com> Add tests cases, ensure `rows` is never nil from showTablets Signed-off-by: Andrew Mason <amason@slack-corp.com> Use `KeywordString` Signed-off-by: Andrew Mason <amason@slack-corp.com> Remove debug log lines, standardize actual log lines Signed-off-by: Andrew Mason <amason@slack-corp.com> Update tests Signed-off-by: Andrew Mason <amason@slack-corp.com> Update the rest of TestExecutorShow to use require/assert Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
… advertise itself as MASTER while mysql is still read_only Signed-off-by: deepthi <deepthi@planetscale.com>
tm: call SetReadOnly inside ChangeTabletType
Replaced Error with a warning in case parsing of VT_SPAN_CONTEXT fails
…r-keyspace-upstream Fixes long wait filter keyspace
Slack vitess 2020.09.29.r0
* impl+log Signed-off-by: Richard Bailey <rbailey@slack-corp.com> * correctly escape regex Signed-off-by: Richard Bailey <rbailey@slack-corp.com> * simple tests, remove logging Signed-off-by: Richard Bailey <rbailey@slack-corp.com> * years are dumb Signed-off-by: Richard Bailey <rbailey@slack-corp.com> * handle the other tow RE cases. this is ... mabye a bit much with the factoring out but maybe not Signed-off-by: Richard Bailey <rbailey@slack-corp.com> * fix up comments, move impls around Signed-off-by: Richard Bailey <rbailey@slack-corp.com> * better better error comment <_< Signed-off-by: Richard Bailey <rbailey@slack-corp.com> * assert! Signed-off-by: Richard Bailey <rbailey@slack-corp.com> * to run test suite Signed-off-by: Richard Bailey <rbailey@slack-corp.com> * fix up testsv Signed-off-by: Richard Bailey <rbailey@slack-corp.com> * tests pass; remove dead code-as-comments Signed-off-by: Richard Bailey <rbailey@slack-corp.com> * pull out unnecessary processing Signed-off-by: Richard Bailey <rbailey@slack-corp.com> * don't differentiate trailing vs leading clarification Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
|
LGTM |
rafael
previously approved these changes
Dec 8, 2020
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent change reviewed upstream here.
Released in 8.0 but we'd like to pick it up here to start experimenting with it before our next deploy.