This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Slack vitess 9 2021.05.18r6 #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
[9.0] fix regression - should be able to plan subquery on top of subquery
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
1. Update the shard sessions only if there is any update i.e. updated transaction id or updated reserved id 2. If there is failure to execute BeginExecute api and the connection is reserved conn then check if shard session can be reset and execute ReserveBeginExecute api Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…erve connection Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
[9.0] Fix for reserved connection usage with transaction
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
[9.0] Fix MySQL Workbench failure on login with `select current_user()`
…n error or times out Signed-off-by: deepthi <deepthi@planetscale.com>
…r timeout from healthcheck stream Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Healthcheck: update healthy tablets correctly when a stream returns an error or times out
Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
[9.0] make sure to handle subqueries on top of subqueries
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
[9.0] make sure to not log sensitive information
Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
[9.0] Fix bug with reserved connections to stale tablets
MoveTables: Refresh SrvVSchema and source tablets on completion
ignore the error and log as warn if not able to validate the current system settings value
VReplication: Pad binlog values for binary() columns to match the value returned by mysql selects
vreplication: fix vreplication timing metrics
…t. Also, Begin and End Maintenance on orchestrator backup: do not restart replication if disable_active_reparents is set. Also, Begin and End Maintenance on orchestrator Signed-off-by: deepthi <deepthi@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Backport: Respect -disable_active_reparents in backup/restore
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Release 9.0.1
Signed-off-by: deepthi <deepthi@planetscale.com>
Backport of vitessio#7430 This is a combination of 6 commits. * added system schema in where clause plan test * added executor unit test * added logic to check table_schema of where clause and redirect to default route if it is a system schema * added e2e test * set the bindvars for the normalized predicates and remove schema name from bv if tablet will replace it * added e2e test having table_schema and table_name in where clause Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>
Fix information_schema query with system schema in table_schema filter
Backport of vitessio#7841 * made sysTableTableSchema a slice and fixed merging for SelectDBA queries * updated tests * added tests * changed error message Signed-off-by: GuptaManan100 <manan@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>
Backport of vitessio#8087 This is a combination of 4 commits. * add e2e test for system schema * add unit test for system schema issue * redirect to default route if not able to resolve the keyspace in case of information_schema query * update test with new error message Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>
…ports Information schema backports
Backport of vitessio#8089 This is a combination of 3 commits. * remove precheck of tablet serving and target * remove the additional logic and return error if queryservice not found to serve query * fix test as per new change Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>
…osition update Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
9.0.0: update release notes with known issue vitessio#8080
Signed-off-by: deepthi <deepthi@planetscale.com>
[9.0] Queryservice fix
[9.0] restore: check disable_active_reparents properly before waiting for position update
ajm188
reviewed
May 19, 2021
| @@ -78,7 +78,31 @@ func (tm *TabletManager) RestoreData(ctx context.Context, logger logutil.Logger, | |||
| if tm.Cnf == nil { | |||
| return fmt.Errorf("cannot perform restore without my.cnf, please restart vttablet with a my.cnf file specified") | |||
| } | |||
| return tm.restoreDataLocked(ctx, logger, waitForBackupInterval, deleteBeforeRestore) | |||
| // Tell Orchestrator we're stopped on purpose for some Vitess task. | |||
There was a problem hiding this comment.
I'm surprised that we didn't already have this change. But in any case, calling it out as being related to additional orc calls.
There was a problem hiding this comment.
The change is new. It was backported only two weeks ago: vitessio#8063
However, I'm surprised we haven't run into issues due to this.
There was a problem hiding this comment.
I agree. I would have to check the orc code to be sure, but maybe because when we're restoring, mysql isn't reachable so orc just ... mostly ignores the tablet?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description