-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐞 Bug Report: The shortcut keys in the popup menu item are misaligned. #298
Labels
bug
Something isn't working
fixed in next release
The issue will be closed once next release is available
Comments
Hello phlpsong, Thank you for your first issue contribution 🎉 |
phlpsong
changed the title
🐞 Bug Report:
🐞 Bug Report: The shortcut keys in the popup menu item are misaligned.
Jan 3, 2024
看了,但没看懂,⌘Q 快捷键有问题? |
The menu item in the storyboard is fine. You can check and compare the screenshot in ReadMe with the current appearance. I believe It's a side effect of the function |
phlpsong
added a commit
to phlpsong/Easydict
that referenced
this issue
Jan 3, 2024
tisfeng
added a commit
that referenced
this issue
Jan 3, 2024
* fix: issue #298 menu item alignment issue * fix: update format * Update Easydict/Feature/StatusItem/EZMenuItemManager.m Co-authored-by: Tisfeng <tisfeng@gmail.com> --------- Co-authored-by: Tisfeng <tisfeng@gmail.com>
tisfeng
added
the
fixed in next release
The issue will be closed once next release is available
label
Jan 3, 2024
这种只合并了 PR 但还未发布新版本的 issue 一般不用手动关闭, 我会在后面发新版本时统一关闭,不然可能会让其他用户产生误解。 |
OK, got it. |
2.5.0 版本已修复该问题。 |
tisfeng
added a commit
that referenced
this issue
Jan 6, 2024
* fix: issue #298 menu item alignment issue * fix: update format * Update Easydict/Feature/StatusItem/EZMenuItemManager.m Co-authored-by: Tisfeng <tisfeng@gmail.com> --------- Co-authored-by: Tisfeng <tisfeng@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
fixed in next release
The issue will be closed once next release is available
Please confirm the following:
Problem description
The shortcut keys like
⌘Q
in the popup menu item are misaligned.Reproduction steps
Open the status bar icon, and check the menu item.
Screenshot
Expected result
Aligned well
Proposed solution (optional)
No response
Device type and OS version
MacOS 14.2.1, Easydict 2.4.1
Are you willing to submit a PR to fix this issue?
The text was updated successfully, but these errors were encountered: