bugfix: menu item alignment issue #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisfeng
requested changes
Jan 3, 2024
There was a problem hiding this comment.
试了一下，这种方式确实可以 😃
我之前好像也看过这个回答 https://stackoverflow.com/a/18034142/8378840 ，但我对 NSMenuItem 不了解，不清楚这个原理是什么，就没有尝试。你能稍微解释一下么？
tisfeng
requested changes
Jan 3, 2024
Co-authored-by: Tisfeng <tisfeng@gmail.com>
tisfeng
approved these changes
Jan 3, 2024
|
很棒，欢迎更多的 PR 👍 |
Thanks! Sure ~ |
tisfeng
added a commit
that referenced
this pull request
Jan 6, 2024
* fix: issue #298 menu item alignment issue * fix: update format * Update Easydict/Feature/StatusItem/EZMenuItemManager.m Co-authored-by: Tisfeng <tisfeng@gmail.com> --------- Co-authored-by: Tisfeng <tisfeng@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#298 menu item alignment issue
Before:
After:
@tisfeng appreciate it if you could review this PR.