feat: support Maven 4.0.0-beta-4 #8
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
There was a problem hiding this comment.
@gnodet here is a fork to os-maven-plugin and I'm going to merge this and release 0.4.0 for the integration.
If you can take a look for review, it would be great.
This work is based on your patch trustin/os-maven-plugin#74
| /** | ||
| * Describe why. | ||
| */ | ||
| public static void disable() { |
There was a problem hiding this comment.
This looks a bit hack. Perhaps we can add more explanation to it.
cc @gnodet
tisonkun
force-pushed
the
patch-maven-4.0
branch
from
f73d506
to
0ef44ee
Compare
| try { | ||
| repoSessionProps.putAll(dict); | ||
| } catch (Exception ex2) { | ||
| // In Maven 4, DefaultCloseableSession uses an immutable map |
There was a problem hiding this comment.
I test locally that only with this change (i.e., no DetectPropertyContributor and the disbale thing), it seems this plugin can work properly also.
There was a problem hiding this comment.
Yes, it can be simplified. If needed, we may want to release a Maven 3 plugin and a Maven 4 plugin separately. I've raised #9, but feel free to cherry-pick to this PR (I could not push to it).
|
In favor of #9. |
No description provided.