Support Maven 4 and JDK 21 at build time #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
changed the title
This was referenced Feb 20, 2024
9 tasks
|
@trustin do you have any plan to work on a new release of |
tisonkun
reviewed
Sep 23, 2024
| @@ -70,6 +70,7 @@ public Detector(SystemPropertyOperationProvider systemPropertyOperationProvider, | |||
| } | |||
|
|
|||
| protected void detect(Properties props, List<String> classifierWithLikes) { | |||
| new Throwable().printStackTrace(); | |||
There was a problem hiding this comment.
For debugging only? Shall we may remove this before merging?
tisonkun
reviewed
Sep 23, 2024
| @@ -25,6 +25,7 @@ | |||
|
|
|||
| import javax.annotation.Nullable; | |||
| import javax.inject.Inject; | |||
| import javax.inject.Singleton; | |||
tisonkun
added a commit
to tisonkun/os-detector
that referenced
this pull request
Sep 23, 2024
Signed-off-by: tison <wander4096@gmail.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR currently contains a dependency on maven alpha-13 snapshot, I'll update it when it's released.