External source map not getting generated with correct file name

[balajisivanath]

Given the following rollup configuration, external css source map is getting generated with file name as "bundle2.css" instead of "bundle.css.map"

import css from "modular-css-rollup";
export default {
    input: "source/exports.js",
    output: {
        file: "out/bundle.js",
        format: "iife",
        name: "test",
        sourcemap: true,
        assetFileNames: "bundle.css" //If this is not given, then modular-css-rollup outputs the file assets/bundle-[hash].css
    },
    plugins: [
        css({
            map: {
                inline: false
            }
        })
    ]
};

Rollup version: 0.62.0
Modular css version: 14.0.1

[tivac]

What happens if you use assetFileNames : "[name][extname]" instead?

It's very similar to what I do in the tests

modular-css/packages/rollup/test/rollup.test.js

Line 24 in 5f1edd6

const assetFileNames = "assets/[name][extname]";

and that looks to generate the expected name based on

modular-css/packages/rollup/test/rollup.test.js

Lines 219 to 243 in 5f1edd6

	it("should generate external source maps", async () => {
	const bundle = await rollup({
	input : require.resolve("./specimens/simple.js"),
	plugins : [
	plugin({
	namer,
	map : {
	inline : false,
	},
	}),
	],
	});
	await bundle.write({
	format,
	assetFileNames,
	file : prefix(`./output/rollup/external-source-maps/simple.js`),
	});
	// Have to parse it into JSON so the propertyMatcher can exclude the file property
	// since it is a hash value and changes constantly
	expect(JSON.parse(read("./rollup/external-source-maps/assets/simple.css.map"))).toMatchSnapshot({
	file : expect.any(String),
	});
	});

[balajisivanath]

What happens if you use assetFileNames : "[name][extname]" instead?

Changing to this format generates file correctly 👍

[tivac]

Weirdly I don't see anywhere in my code that is generating the 2.css version containing the map code, though I can replicate what you're seeing.

I'd argue that the original config value being a hardcoded filename is an incorrect value to pass, but ideally it wouldn't explode things... 😥

[balajisivanath]

Ouch! Sourcemapping url in bundle.css isn't replaced with correct filename

Weirdly I don't see anywhere in my code that is generating the 2.css version containing the map code, though I can replicate what you're seeing.
I'd argue that the original config value being a hardcoded filename is an incorrect value to pass, but ideally it wouldn't explode things... 😥

I guess issue could be in rollup, considering that assetFileName config is under their experimental feature list

[tivac]

Well that sourceMappingURL is definitely a problem. Ugh, the interactions between PostCSS and rollup are a real thing sometimes.

I can fix that one, at least!

[tivac]

Latest release should have this change afaik. Let me know if it doesn't!

…

On Tue, Jul 24, 2018, 5:10 AM balaji-sivanath ***@***.***> wrote: @tivac <https://github.com/tivac> Can you please tag a new release with this fix? Thanks in advance. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#455 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADBia3dgI-AnAKndNpsZ5ZfSteX_V3nks5uJw6-gaJpZM4VUBeF> .

[balajisivanath]

Latest release v14.1.0 is built with this changeset 119e10c. Above fix is merged after that, hence it is not there.

[tivac]

Hrmm, not sure how that missed the 14.1.0 release since I intended it to be part of it. My mistake, I'll try to get to that soonish.

[tivac]

Released in modular-css-rollup@14.2.0, sorry about the delay!