fix: External map references #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that external source map references point to the right file. Gotta pass a real file to postcss or it does some funny things. Fixes #455
tivac
force-pushed
the
external-map-references
branch
from
082a9d6
to
a769269
Compare
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
==========================================
+ Coverage 99.01% 99.01% +<.01%
==========================================
Files 31 31
Lines 810 815 +5
Branches 128 129 +1
==========================================
+ Hits 802 807 +5
Misses 8 8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #455
This won't handle
[hash]but I have no idea what I could possibly do there in that instance, because rollup won't tell me the filename ahead of time (since it can't get the hash until it has the contents, an annoying 🐔 and 🥚 problem).