Add note that only supported on node 8 and above #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had a second go, and moved this under the Support section instead of Installation. I also added a comment about the Issues page, partly to balance the TideLift info. (I don't think Support would be the right place if we enforced the allowed Node version, but feels a reasonable fit since we are saying what we support rather than what is compatible.) |
This was referenced Mar 6, 2020
This was referenced Mar 14, 2020
cscott
added a commit
to cscott/seek-bzip
that referenced
this pull request
Jul 31, 2020
Because of the bump in mocha version to 8.0, we can no longer run tests on Node.js v8.x and below: mochajs/mocha#4164 The fibers package at version 5.0 also doesn't support Node.js v10.x or lower, although it seems to work fine in my limited testing. The commander package requires node 6 or greater: tj/commander.js#1053
cscott
added a commit
to cscott/seek-bzip
that referenced
this pull request
Jul 31, 2020
This version drops compatibility for Node.js <= 10.x, and as such is a semver major version bump. To be clear, the code in this package hasn't changed; we've just bumped the versions of dependencies. The `commander` dep requires node 6 ( tj/commander.js#1053 ) but the dev dependencies require Node.js <= 8.x and are unsupported on Node.js <= 10.x. I can't promise that things that aren't being tested continue to work.
This was referenced Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
We do not have a stated policy for node support, and have long wanted to be able to use some new javascript language features. I would like to be clear for myself what we can and can't use without breaking clients.
Related issue is #1045
Solution
Say that we only support node 8 and higher in the README.
As per #1045, I suggest we actually stick to features supported by node 6 for now.
(I deliberately have not put node 8 as an actual requirement in the
enginesfield in thepackage.jsonsince we are still work on older versions at least currently.)